Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] added unprivileged mapping to kql validation #183239

Merged
merged 4 commits into from
May 14, 2024
Merged

[Fleet] added unprivileged mapping to kql validation #183239

merged 4 commits into from
May 14, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented May 13, 2024 •
edited
Loading

Summary

Fixed error with new unprivileged field search when strict KQL validation is turned on.
https://github.com/elastic/ingest-dev/issues/3250#issuecomment-2101490854

To verify:

  • enable KQL validation to kibana.dev.yml: xpack.fleet.enableExperimental: ['enableStrictKQLValidation']
  • start kibana and enroll an agent with docker
  • search on local_metadata.elastic.agent.unprivileged: true in Agent list UI
  • expect no error
image

@juliaElastic juliaElastic added the release_note:skip Skip the PR/issue when compiling release notes label May 13, 2024
@juliaElastic juliaElastic self-assigned this May 13, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner May 13, 2024 08:57
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

criamico
criamico approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@juliaElastic juliaElastic enabled auto-merge (squash) May 14, 2024 06:31
@juliaElastic juliaElastic merged commit 230e789 into elastic:main May 14, 2024
21 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 163.5KB 163.5KB +30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 14, 2024
@justinkambic justinkambic mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@juliaElastic juliaElastic

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliaElastic @elasticmachine @apmmachine @kibana-ci @criamico @kibanamachine