Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [ES|QL] accept string constants for date args (#182856) #182953

Merged
merged 2 commits into from
May 8, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

## Summary

## String constants in place of dates

As of elastic/elasticsearch#106932 string
constants can always be used in place of dates.

- `| eval date_extract("DAY_OF_WEEK", "2024-05-07T13:20:40.554Z")`
- `| STATS AVG(salary) BY bucket = BUCKET(hire_date, 20,
"1985-01-01T00:00:00Z", "1986-01-01T00:00:00Z")
| SORT bucket`
- `| eval date_diff("day", "2021-01-01", "2022-01-01")`

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 9ddc3c6)
@drewdaemon
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB -605.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @drewdaemon

@kibanamachine kibanamachine merged commit e892aae into elastic:8.14 May 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants