Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Add advanced setting for enabling multi signal views in APM #182862

Merged
merged 3 commits into from
May 8, 2024
Merged

[APM] Add advanced setting for enabling multi signal views in APM #182862

merged 3 commits into from
May 8, 2024

Conversation

kpatticha
Copy link
Contributor

Summary

close #182678

key: observability:apmEnableMultiSignal

image

@kpatticha kpatticha requested review from a team as code owners May 7, 2024 16:55
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels May 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kpatticha
kpatticha commented May 7, 2024
View reviewed changes
x-pack/plugins/observability_solution/observability/server/ui_settings.ts
}),
description: i18n.translate('xpack.observability.apmEnableMultiSignalDescription', {
defaultMessage:
'{technicalPreviewLabel} Enable the multi-signal feature in APM, which allows you to monitor services from logs and traces.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any recommendation to make the description more clear is more than welcomed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @mdbirnstiehl

@kpatticha kpatticha added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 labels May 7, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented May 7, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 134 135 +1
observability 670 678 +8
total +9

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5407 +5407
total size - 8.8MB +8.8MB
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 137 138 +1
observability 679 687 +8
total +9

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

afharo
afharo approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM

dominiqueclarke
dominiqueclarke approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

@kpatticha kpatticha merged commit 216ecd7 into elastic:main May 8, 2024
28 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 8, 2024
@smith smith mentioned this pull request May 16, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes left review comments

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@afharo afharo afharo approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM][Multi-signal service inventory] Introduce a feature flag to enable/disable the multi-signal inventory
10 participants
@kpatticha @elasticmachine @apmmachine @kibana-ci @afharo @bmorelli25 @dominiqueclarke @cauemarcondes @ElenaStoeva @kibanamachine