[SecuritySolution] [UI] Re-score entity when asset criticality changes #182234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machadoum
changed the title
|
/ci |
2 similar comments
|
/ci |
|
/ci |
machadoum
added
Team: SecuritySolution
machadoum
force-pushed
the
siem-ea-9121-2
branch
2 times, most recently
from
b540632 to
4287820
Compare
machadoum
commented
May 3, 2024
| const timerange = useMemo(() => { | ||
| const from = dateMath.parse(LAST_30_DAYS.from)?.toISOString() ?? LAST_30_DAYS.from; | ||
| const to = dateMath.parse(LAST_30_DAYS.to)?.toISOString() ?? LAST_30_DAYS.to; | ||
| return { from, to }; | ||
| }, []); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [riskDataTimestamp]); // Update the timerange whenever the risk score timestamp changes to include new entries |
There was a problem hiding this comment.
This change is necessary to update the embedded visualization
machadoum
commented
May 3, 2024
| /> | ||
| ), | ||
| }, | ||
| link: riskScoreData.loading |
There was a problem hiding this comment.
This change fixes a cypress flakiness, it was clicking on the link before riskScoreData was loaded.
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
|
/ci |
angorayc
reviewed
May 7, 2024
x-pack/plugins/security_solution/public/explore/hosts/pages/details/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/explore/users/pages/details/index.tsx
Outdated
Show resolved
Hide resolved
angorayc
approved these changes
May 8, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the risk score when the user updates asset criticality.
recalculate.risk.score.2.mov
recalculate.risk.score.mov
Tech breakdown
Required changes
refresh: 'wait_for'inspectedso we can refetch it from anywhere.Sequence of events
calculateEntityRiskScorecalculateEntityRiskScoreresponsesequenceDiagram participant FE as Client participant BE as Server FE->>BE: Assign Asset Criticality BE->>FE: Asset Criticality Response FE->>BE: Recalculate Risk Score BE->>FE: Risk Score Response FE->>BE: Fetch visualizations 1 FE->>BE: Fetch visualizations 2 FE->>BE: Fetch visualizations 3 BE->>FE: Visualizations responsesAffected components:
Why we don't have cypres tests?
Checklist
Delete any items that are not applicable to this PR.