Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename SerializedMapState to ParsedMapStateJSON and SerializedUiState to ParsedUiStateJSON #182185

Merged
merged 2 commits into from
Apr 30, 2024
Merged

rename SerializedMapState to ParsedMapStateJSON and SerializedUiState to ParsedUiStateJSON #182185

merged 2 commits into from
Apr 30, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 30, 2024 •
edited
Loading

Part of #174960

#178158 creates a new type MapSerializeState. This new type name is very confusing with existing SerializedMapState type name. This PR renames SerializedMapState to ParsedMapStateJSON to avoid this confusion. Breaking this change out of #174960 to make things clearer and avoid confusion during reviewing #174960

@nreese nreese requested a review from a team as a code owner April 30, 2024 18:34
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.15.0 labels Apr 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese changed the title rename SerializedMapState to ParsedMapStateJSON and SerializedUiState to ParsedUiState rename SerializedMapState to ParsedMapStateJSON and SerializedUiState to ParsedUiStateJSON Apr 30, 2024
nickpeihl
nickpeihl approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! code review

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 3.0MB 3.0MB -40.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit daf81a6 into elastic:main Apr 30, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nreese @elasticmachine @kibana-ci @nickpeihl @kibanamachine