Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Embeddables Rebuild] Example aesthetics #181920

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[Embeddables Rebuild] Example aesthetics #181920

merged 3 commits into from
Apr 29, 2024

Conversation

ThomThomson
Copy link
Contributor

Slight aesthetic changes to the example embeddables:

  • The grouping now has an icon
Screenshot 2024-04-26 at 5 06 04 PM
  • The search example has a nicer UI
Screenshot 2024-04-26 at 5 05 51 PM

@ThomThomson ThomThomson added loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:Embeddables Relating to the Embeddable system project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes labels Apr 26, 2024
@ThomThomson
Copy link
Contributor Author

/ci

@ThomThomson ThomThomson marked this pull request as ready for review April 29, 2024 16:22
@ThomThomson ThomThomson requested a review from a team as a code owner April 29, 2024 16:22
@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@nreese nreese self-requested a review April 29, 2024 16:26
nreese
nreese approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review only

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #86 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 102c207 into elastic:main Apr 29, 2024
18 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Embeddables Relating to the Embeddable system impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ThomThomson @kibana-ci @nreese @kibanamachine