Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mappings Editor] Disable _source field in serverless #181712
[Mappings Editor] Disable _source field in serverless #181712
Changes from 4 commits
72d4c64
e019e0a
04dacec
e18e1f5
8818654
06d98ba
813297e
d7359e4
5d775db
ef8ebef
e120b9a
32946b9
b9c1a1a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could we just move this down below the comment with the other conditional flags, or comment as 'any' due to offering based schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I moved it below the comment as well as the rest of the index management offering-based configs for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about renaming the config to
enableMappingsSourceFieldConfiguration
but this might be too long. I'm open to any suggestions for the name of the config.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about
enableMappingsSourceFieldConfig
orenableMappingsSourceFieldSection
? A little shorter, but not much 😅 . I'm also OK to leave it how you have it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestions! I like
enableMappingsSourceFieldSection
since the component for the _source field configuration is calledSourceFieldSection
. Added this change with 813297e.