Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLOs] Add/edit form show tags suggestions #181075

Merged
merged 3 commits into from
Apr 18, 2024
Merged

[SLOs] Add/edit form show tags suggestions #181075

merged 3 commits into from
Apr 18, 2024

Conversation

shahzad31
Copy link
Contributor

Summary

Show tags as suggestions from existing SLOs

image

@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Apr 17, 2024
@shahzad31 shahzad31 requested a review from a team as a code owner April 17, 2024 18:44
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

kdelemme
kdelemme reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just introduce a response type in the slo-schema for this new API, and use that in the hooks, and it's golden ✨

x-pack/plugins/observability_solution/slo/server/routes/slo/route.ts Outdated
Comment on lines 459 to 460
const findSLOGroups = new GetSLOSuggestions(soClient);
return await findSLOGroups.execute();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const findSLOGroups = new GetSLOSuggestions(soClient);
return await findSLOGroups.execute();
const getSLOSuggestions = new GetSLOSuggestions(soClient);
return await getSLOSuggestions.execute();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooopsssss

x-pack/plugins/observability_solution/slo/server/services/get_slo_suggestions.ts
Comment on lines +9 to +18
type Buckets = Array<{
key: string;
doc_count: number;
}>;

interface AggsResponse {
tagsAggs: {
buckets: Buckets;
};
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to introduce a type in slo-schema, so we can also import it in the hook/ui?

x-pack/plugins/observability_solution/slo/public/pages/slo_edit/hooks/use_fetch_suggestions.ts Outdated
Comment on lines 11 to 15
export interface Suggestion {
label: string;
value: string;
count: number;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe introduce a slo-schema response for this API, and we can use it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@shahzad31 shahzad31 requested a review from kdelemme April 18, 2024 07:46
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 509 510 +1
slo 721 723 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/slo-schema 171 173 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 723.2KB 723.7KB +511.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 150.6KB 150.7KB +85.0B
Unknown metric groups

API count

id before after diff
@kbn/slo-schema 171 173 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kdelemme
kdelemme approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit d3207ec into elastic:main Apr 18, 2024
16 checks passed
@shahzad31 shahzad31 deleted the tags branch April 18, 2024 13:46
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 18, 2024
@shahzad31 shahzad31 mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @apmmachine @kibana-ci @kdelemme @kibanamachine