Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SLOs] Refetch data views on save #181033

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 17, 2024

Summary

Refetch data views on save !!

Fixes #179478

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review April 17, 2024 12:59
@shahzad31 shahzad31 requested a review from a team as a code owner April 17, 2024 12:59
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Apr 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 723.2KB 723.3KB +12.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
observability 14 13 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 150.6KB 150.6KB +20.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 86df2fc into elastic:main Apr 18, 2024
18 checks passed
@shahzad31 shahzad31 deleted the refetch-data-views branch April 18, 2024 07:48
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 18, 2024
## Summary

Refetch data views on save !!

Fixes elastic#179478

(cherry picked from commit 86df2fc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 18, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [[SLOs] Refetch data views on save
(#181033)](#181033)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-04-18T07:48:08Z","message":"[SLOs]
Refetch data views on save (#181033)\n\n## Summary\r\n\r\nRefetch data
views on save !!\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179478","sha":"86df2fc9ae9c71b6d3e22ebdcc850bdf113c1fb3","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","v8.14.0","v8.15.0"],"title":"[SLOs]
Refetch data views on
save","number":181033,"url":"https://github.com/elastic/kibana/pull/181033","mergeCommit":{"message":"[SLOs]
Refetch data views on save (#181033)\n\n## Summary\r\n\r\nRefetch data
views on save !!\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179478","sha":"86df2fc9ae9c71b6d3e22ebdcc850bdf113c1fb3"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181033","number":181033,"mergeCommit":{"message":"[SLOs]
Refetch data views on save (#181033)\n\n## Summary\r\n\r\nRefetch data
views on save !!\r\n\r\nFixes
https://github.com/elastic/kibana/issues/179478","sha":"86df2fc9ae9c71b6d3e22ebdcc850bdf113c1fb3"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Newly created data view is not visible in the list in create SLO form
6 participants