[ObsUx] [Infra] Change container details view with asset details view #180436

MiriamAparicio · 2024-04-10T07:30:22Z

Part of #179844

In this PR

From Inventory, open asset details page view for Containers
Show overview tab with CPU and Memory KPIs and metric charts
Metadata tab with old fields, more metadata fields will be shown in follow-up PR
Added links to container metrics documentation, currently there are no docs for K8s metrics just for docker containers

How to test

The feature is under a FF, on inventory page go to settings and enable Container view
In containers inventory, select a container and click on 'Docker container metrics' link (there's an issue to reword this links as K8s containers are also shown)
Container details page should be shown with overview and metadata tabs
On overview tab KPIs for CPU and Memory and Metrics section with CPU and Memory charts should be displayed

…details page

apmmachine · 2024-04-10T07:30:36Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…set.name

…set-details-view

elasticmachine · 2024-05-02T10:57:32Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

…y_solution

…set-details-view

smith · 2024-05-03T18:54:17Z

/oblt-deploy-serverless

…set-details-view

crespocarlos

LGMT! Thanks for this PR. Left a couple of nits, but it's ok to merge.

...y_solution/infra/public/components/asset_details/tabs/overview/metrics/container_metrics.tsx

crespocarlos · 2024-05-15T15:54:55Z

...ns/observability_solution/infra/public/components/asset_details/charts/kubernetes_charts.tsx

-    dataViewId: dataView?.id,
-    options: { overview },
-  });
+export const KubernetesNodeCharts = React.forwardRef<HTMLDivElement, MetricsChartsFields>(


Thanks for moving this component into this file.

crespocarlos · 2024-05-15T15:56:07Z

x-pack/test/functional/apps/infra/home_page.ts

+            await infraSynthtraceKibanaClient.installSystemPackage(version);
+            synthEsClient = await getInfraSynthtraceEsClient(esClient);
+            await synthEsClient.index(
+              generateDockerContainersData({


crespocarlos · 2024-05-15T15:56:37Z

x-pack/test/functional/apps/infra/node_details.ts

+
+          await pageObjects.assetDetails.clickOverviewTab();
+        });
+        // Add this test after implementing the creation of metadata for containers in sythtrace


Do we need to merge these commented-out lines?

No, we don't need to merge them, was just a reminder to add those test when we can see the metrics data

…set-details-view

elasticmachine · 2024-05-16T09:34:55Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

afharo

Changes in the UI settings collector LGTM.

yuliacech

UI settings constant LGTM 👍

weltenwort

changes to synthtrace code co-owned by obs-ux-logs LGTM 👍

kibana-ci · 2024-05-16T10:41:20Z

💚 Build Succeeded

Buildkite Build
Commit: 3ca0f23
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-180436-3ca0f239e345
Observability Deployment

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`infra`	1556	1561	+5
`metricsDataAccess`	275	281	+6
total			+11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace-client`	191	193	+2
`@kbn/management-settings-ids`	135	136	+1
`observability`	678	686	+8
total			+11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.5MB	1.5MB	+8.0KB
`metricsDataAccess`	85.2KB	97.8KB	+12.6KB
total			+20.6KB

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id	before	after	diff
`module count`	-	5405	+5405
`total size`	-	8.8MB	+8.8MB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/apm-synthtrace-client`	28	30	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`metricsDataAccess`	56.9KB	57.0KB	+160.0B
`observability`	151.3KB	151.5KB	+237.0B
total			+397.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/apm-synthtrace-client`	191	193	+2
`@kbn/management-settings-ids`	138	139	+1
`observability`	687	695	+8
total			+11

async chunk count

id	before	after	diff
`metricsDataAccess`	6	8	+2

ESLint disabled in files

id	before	after	diff
`@kbn/apm-synthtrace-client`	3	4	+1

Total ESLint disabled count

id	before	after	diff
`@kbn/apm-synthtrace-client`	5	6	+1

History

💚 Build #210116 succeeded a89627f5d1a2f20b02a8cccc49c18a7c7a2f8534
💔 Build #210037 failed ba3d65f77774b48b79c064d24ac18b973adc8353
💔 Build #209865 failed b76b1f4b6f39923c63aa2c163a9730399dac6f71
💔 Build #209769 failed df438e249a527dcba9fae42752c567e3d9539e0d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

MiriamAparicio added 2 commits April 10, 2024 08:26

use asset details for container details view, set tabs for container …

75be34e

…details page

add formulas and charts for container metrics

0b07216

MiriamAparicio added 8 commits April 12, 2024 14:31

add synthtrace scenario for containers and use asset.id instead of as…

a0c7310

…set.name

add formulas and charts for container k8s

0a25326

fix conflicts, wip

e5ef7b7

added cpu, memory sections, improvements

723c573

Merge remote-tracking branch 'upstream/main' into 179844-container-as…

0af4da1

…set-details-view

added KPI in container overview tab

a8b87c6

delete comment, link is working now

612ed5d

Merge remote-tracking branch 'upstream/main' into 179844-container-as…

da0639f

…set-details-view

MiriamAparicio marked this pull request as ready for review May 2, 2024 10:56

MiriamAparicio requested review from a team as code owners May 2, 2024 10:56

MiriamAparicio added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels May 2, 2024

botelastic bot added the ci:project-deploy-observability Create an Observability project label May 2, 2024

crespocarlos self-requested a review May 2, 2024 11:21

fix conflicts after metric_data_access has been moved to observabilit…

6f1973f

…y_solution

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from 026620f to 6f1973f Compare May 2, 2024 15:36

MiriamAparicio added 2 commits May 2, 2024 16:36

Merge remote-tracking branch 'upstream/main' into 179844-container-as…

1c1b1dd

…set-details-view

fix i18n duplicate

07eadf0

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from 365ced1 to 07eadf0 Compare May 2, 2024 16:29

MiriamAparicio added 3 commits May 6, 2024 11:22

fix tests

ab3359c

fix type

c60d2da

Merge remote-tracking branch 'upstream/main' into 179844-container-as…

ce49d33

…set-details-view

MiriamAparicio added 2 commits May 9, 2024 17:00

fix type

3b5f01e

fix missing renaming

7753742

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from 62b894b to 7753742 Compare May 10, 2024 13:29

added some e2e test for container details view

a69a97b

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from b5f7604 to a69a97b Compare May 13, 2024 16:13

remove load of not used archiver

8c12e90

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from ba3d65f to 8c12e90 Compare May 15, 2024 11:07

crespocarlos approved these changes May 15, 2024

View reviewed changes

MiriamAparicio added 2 commits May 16, 2024 10:12

added FF for container asset view and e2e tests

f657e3e

Merge remote-tracking branch 'upstream/main' into 179844-container-as…

8fc3332

…set-details-view

MiriamAparicio force-pushed the 179844-container-asset-details-view branch from a89627f to 8fc3332 Compare May 16, 2024 09:14

MiriamAparicio requested review from a team as code owners May 16, 2024 09:14

shahzad31 approved these changes May 16, 2024

View reviewed changes

botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label May 16, 2024

Merge branch 'main' into 179844-container-asset-details-view

3ca0f23

afharo approved these changes May 16, 2024

View reviewed changes

yuliacech approved these changes May 16, 2024

View reviewed changes

weltenwort approved these changes May 16, 2024

View reviewed changes

sebelga approved these changes May 16, 2024

View reviewed changes

bmorelli25 approved these changes May 16, 2024

View reviewed changes

MiriamAparicio merged commit a4579a7 into elastic:main May 16, 2024
21 checks passed

kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024

MiriamAparicio deleted the 179844-container-asset-details-view branch May 16, 2024 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ObsUx] [Infra] Change container details view with asset details view #180436

[ObsUx] [Infra] Change container details view with asset details view #180436

MiriamAparicio commented Apr 10, 2024 •

edited

Loading

apmmachine commented Apr 10, 2024

elasticmachine commented May 2, 2024

smith commented May 3, 2024

crespocarlos left a comment

crespocarlos May 15, 2024

crespocarlos May 15, 2024

crespocarlos May 15, 2024

MiriamAparicio May 16, 2024

elasticmachine commented May 16, 2024

afharo left a comment

yuliacech left a comment

weltenwort left a comment

kibana-ci commented May 16, 2024 •

edited

Loading

API count

async chunk count

ESLint disabled in files

Total ESLint disabled count

[ObsUx] [Infra] Change container details view with asset details view #180436

[ObsUx] [Infra] Change container details view with asset details view #180436

Conversation

MiriamAparicio commented Apr 10, 2024 • edited Loading

In this PR

How to test

apmmachine commented Apr 10, 2024

🤖 GitHub comments

elasticmachine commented May 2, 2024

smith commented May 3, 2024

crespocarlos left a comment

Choose a reason for hiding this comment

crespocarlos May 15, 2024

Choose a reason for hiding this comment

crespocarlos May 15, 2024

Choose a reason for hiding this comment

crespocarlos May 15, 2024

Choose a reason for hiding this comment

MiriamAparicio May 16, 2024

Choose a reason for hiding this comment

elasticmachine commented May 16, 2024

afharo left a comment

Choose a reason for hiding this comment

yuliacech left a comment

Choose a reason for hiding this comment

weltenwort left a comment

Choose a reason for hiding this comment

kibana-ci commented May 16, 2024 • edited Loading

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Canvas Sharable Runtime

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled in files

Total ESLint disabled count

History

MiriamAparicio commented Apr 10, 2024 •

edited

Loading

kibana-ci commented May 16, 2024 •

edited

Loading