[embeddable rebuild] useBatchedOptionalPublishingSubjects #180221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
ThomThomson
approved these changes
Apr 8, 2024
packages/presentation/presentation_publishing/publishing_subject/publishing_batcher.ts
Outdated
Show resolved
Hide resolved
packages/presentation/presentation_publishing/publishing_subject/publishing_batcher.ts
Show resolved
Hide resolved
packages/presentation/presentation_publishing/publishing_subject/publishing_batcher.ts
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
…-cache --fix'" This reverts commit 3d67df3.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
Heenawter
approved these changes
Apr 9, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
eokoneyo
approved these changes
Apr 10, 2024
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Apr 10, 2024
…0221) Fixes elastic#180088 1. Changes observable pipe from `debounceTime(), skip(1)` to `skip(1), debounceTime()`. Updates test to verify this change results in subscription getting fired when observable.next is called before debounceTime fires. 2. rename `useBatchedPublishingSubjects` to `useBatchedOptionalPublishingSubjects`. Remove `useMemo` since spreading subjects results in new array every time and useMemo does nothing. 3. Update `PresentationPanelInternal` to use `useBatchedOptionalPublishingSubjects` 4. create new `useBatchedPublishingSubjects` that types subjects as `PublishingSubject[]`. New --------- Co-authored-by: Kibana Machine <[email protected]>
semd
added a commit
to semd/kibana
that referenced
this pull request
Apr 10, 2024
…astic#180221)" This reverts commit 51c3fa5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180088
debounceTime(), skip(1)toskip(1), debounceTime(). Updates test to verify this change results in subscription getting fired when observable.next is called before debounceTime fires.useBatchedPublishingSubjectstouseBatchedOptionalPublishingSubjects. RemoveuseMemosince spreading subjects results in new array every time and useMemo does nothing.PresentationPanelInternalto useuseBatchedOptionalPublishingSubjectsuseBatchedPublishingSubjectsthat types subjects asPublishingSubject[]. New