Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Investigations] Fixes notes tab test in MKI #179059

Merged
merged 3 commits into from
Mar 20, 2024
Merged

[Security Solution][Investigations] Fixes notes tab test in MKI #179059

merged 3 commits into from
Mar 20, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Mar 20, 2024 •
edited
Loading

Summary

The tests that were using the author in assertions for the notes tab tests in timeline, are failing in MKI

This is because we are hardcoding the username as system_indices_superuser, but that one, does not exist on MKI projects.

In this PR we are fixing the issue.

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema changed the title fixes [Security Solution][Investigations] Fixes notes tab test in MKI Mar 20, 2024
@MadameSheema MadameSheema self-assigned this Mar 20, 2024
@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.14.0 labels Mar 20, 2024
@MadameSheema MadameSheema marked this pull request as ready for review March 20, 2024 14:52
@MadameSheema MadameSheema requested a review from a team as a code owner March 20, 2024 14:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

MadameSheema and others added 2 commits March 20, 2024 18:26
@MadameSheema @michaelolo24
Update x-pack/test/security_solution_cypress/cypress/e2e/investigatio…
82c5f26 
…ns/timelines/notes_tab.cy.ts

Co-authored-by: Michael Olorunnisola <[email protected]>
@MadameSheema
refactor
ab59fce
michaelolo24
michaelolo24 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄

@MadameSheema MadameSheema enabled auto-merge (squash) March 20, 2024 18:42
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / Dataset Quality Dataset quality table filters hides inactive datasets when toggled

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit ee238c3 into elastic:main Mar 20, 2024
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 20, 2024
@thomheymann thomheymann mentioned this pull request Mar 26, 2024
Merged
@MadameSheema MadameSheema deleted the fixing-notes-tab-test-on-mki branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibana-ci @michaelolo24 @kibanamachine