Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Consolidate chart switch into one layer chart switch #178864

Closed
wants to merge 6 commits into from
Closed

[Lens] Consolidate chart switch into one layer chart switch #178864

wants to merge 6 commits into from

Conversation

mbondyra
Copy link
Contributor

Summary

Fixes #163721

@mbondyra mbondyra added release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens v8.14.0 labels Mar 18, 2024
@mbondyra
Copy link
Contributor Author

/ci

@mbondyra mbondyra force-pushed the chart_switch_poc2 branch from 744dbf4 to 4a394ce Compare March 18, 2024 13:17
@mbondyra
Copy link
Contributor Author

/ci

@mbondyra mbondyra force-pushed the chart_switch_poc2 branch from 4a394ce to abad537 Compare March 18, 2024 14:18
@mbondyra
Copy link
Contributor Author

/ci

@mbondyra mbondyra force-pushed the chart_switch_poc2 branch from abad537 to 63a5134 Compare March 19, 2024 13:23
@mbondyra
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Mar 19, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / LayerHeader should render chart switch if custom layer header was not passed
  • [job] [logs] Jest Tests #5 / LayerHeader should render chart switch if custom layer header was not passed
  • [job] [logs] FTR Configs #45 / lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have differents chart types
  • [job] [logs] FTR Configs #45 / lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have differents chart types
  • [job] [logs] FTR Configs #71 / lens app - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #94 / lens app - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #71 / lens app - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #94 / lens app - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #60 / lens app - group 4 lens color palette tests should carry over palette to the pie chart
  • [job] [logs] FTR Configs #60 / lens app - group 4 lens color palette tests should carry over palette to the pie chart
  • [job] [logs] FTR Configs #96 / lens app - group 5 lens gauge should reflect edits for gauge
  • [job] [logs] FTR Configs #96 / lens app - group 5 lens gauge should reflect edits for gauge
  • [job] [logs] FTR Configs #19 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #23 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #26 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #23 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #26 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #19 / lens serverless - group 1 lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #28 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #38 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #43 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #28 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #38 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #43 / Sanity checks lens app lens smokescreen tests should transition from bar chart to line chart using layer chart switch
  • [job] [logs] FTR Configs #1 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types
  • [job] [logs] FTR Configs #3 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types
  • [job] [logs] FTR Configs #88 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types
  • [job] [logs] FTR Configs #3 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types
  • [job] [logs] FTR Configs #1 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types
  • [job] [logs] FTR Configs #88 / Visualizations - Group 2 lens app - Agg based Vis Open in Lens XY should convert in different layers if metrics have different chart types

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1347 1349 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 564 569 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -82.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lens 45.8KB 45.8KB +1.0B
Unknown metric groups

API count

id before after diff
lens 665 670 +5

History

  • 💔 Build #198008 failed abad53722846f497cb935dafdf7d88720cebceb4
  • 💔 Build #197993 failed 4a394ce570eee7d55619fcb1997e033833445f68
  • 💔 Build #197979 failed 744dbf4b28b0690fbc2fa4c0291b7372fca75380

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra closed this Mar 19, 2024
@mbondyra mbondyra deleted the chart_switch_poc2 branch March 19, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature:Lens release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Presence Of Dual Chart Selectors Is Confusing
2 participants
@mbondyra @kibana-ci