-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Check if license management plugin is enabled before linking #178773
Merged
justinkambic
merged 6 commits into
elastic:main
from
justinkambic:153030/check-if-licenseManagement-plugin-is-enabled-before-linking
Mar 22, 2024
Merged
[Synthetics] Check if license management plugin is enabled before linking #178773
justinkambic
merged 6 commits into
elastic:main
from
justinkambic:153030/check-if-licenseManagement-plugin-is-enabled-before-linking
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.14.0
labels
Mar 14, 2024
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
justinkambic
force-pushed
the
153030/check-if-licenseManagement-plugin-is-enabled-before-linking
branch
from
March 21, 2024 18:52
167cde1
to
1d42fec
Compare
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
cauemarcondes
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jloleysens
approved these changes
Mar 22, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
justinkambic
deleted the
153030/check-if-licenseManagement-plugin-is-enabled-before-linking
branch
March 22, 2024 19:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
v8.14.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #153030.
Essentially, we add
licenseManagement
as an optional dep, and check if it's enabled before we link to it.