Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Check if license management plugin is enabled before linking #178773

Conversation

justinkambic
Copy link
Contributor

Summary

Resolves #153030.

Essentially, we add licenseManagement as an optional dep, and check if it's enabled before we link to it.

@justinkambic justinkambic added release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0 labels Mar 14, 2024
@justinkambic justinkambic self-assigned this Mar 14, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@justinkambic justinkambic force-pushed the 153030/check-if-licenseManagement-plugin-is-enabled-before-linking branch from 167cde1 to 1d42fec Compare March 21, 2024 18:52
@justinkambic justinkambic marked this pull request as ready for review March 21, 2024 18:56
@justinkambic justinkambic requested review from a team as code owners March 21, 2024 18:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #25 / Saved objects management should be able to handle multi-space imports correctly copied dashboard from another space into third space using saved objects table should render correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 848.5KB 848.7KB +251.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit 5fbae0a into elastic:main Mar 22, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 22, 2024
@justinkambic justinkambic deleted the 153030/check-if-licenseManagement-plugin-is-enabled-before-linking branch March 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics] Check is License Management is enabled when linking to it
7 participants