Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix flaky test by adding host.mac to all the fake_hosts documents #178648

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Attempt to fix flaky test by adding host.mac to all the fake_hosts documents #178648

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6b92f
Add host.mac to all the fake_hosts documents
maryam-saeidi Mar 13, 2024
682d557
Merge branch 'main' into 178578-fix-host-mac-issue
maryam-saeidi Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/packages/kbn-data-forge/src/data_sources/fake_hosts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ export const generateEvent: GeneratorFunction = (config, schedule, index, timest
'@timestamp': timestamp.toISOString(),
host: {
name: `host-${index}`,
mac: ['00-00-5E-00-53-23', '00-00-5E-00-53-24'],
Copy link
Member Author

@maryam-saeidi maryam-saeidi Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simianhacker I've added host.mac to all the docs in fake_hosts, please let me know if you see an issue.

Thanks for pointing to this fix!

network: {
name: `network-${index}`,
ingress: {
Expand Down Expand Up @@ -134,6 +135,7 @@ export const generateEvent: GeneratorFunction = (config, schedule, index, timest
'@timestamp': timestamp.toISOString(),
host: {
name: `host-${index}`,
mac: ['00-00-5E-00-53-23', '00-00-5E-00-53-24'],
network: {
name: `network-${index}`,
},
Expand Down
Loading