Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added doc for capture_command_line advanced options #178617

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

bit-envoy
Copy link
Contributor

@bit-envoy bit-envoy commented Mar 13, 2024

Summary

Added doc for capture_command_line advanced options

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@bit-envoy bit-envoy requested a review from a team as a code owner March 13, 2024 11:17
@bit-envoy bit-envoy self-assigned this Mar 13, 2024
@bit-envoy bit-envoy requested a review from gabriellandau March 13, 2024 11:18
@gabriellandau gabriellandau added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. QA:Needs Validation Issue needs to be validated by QA labels Mar 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #6 / Response console Host Isolation: should isolate a host from response console should isolate a host from response console

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @bit-envoy

@bit-envoy bit-envoy added the release_note:skip Skip the PR/issue when compiling release notes label Mar 14, 2024
@bit-envoy bit-envoy merged commit a2b100c into main Mar 14, 2024
41 checks passed
@bit-envoy bit-envoy deleted the add_capture_command_line_docs branch March 14, 2024 07:13
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting QA:Needs Validation Issue needs to be validated by QA release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants