Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flamegraph regression #178511

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Mar 12, 2024

Fix a regression introduced in #178481

@rockdaboot rockdaboot added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.13.0 v8.14.0 labels Mar 12, 2024
@rockdaboot rockdaboot self-assigned this Mar 12, 2024
@rockdaboot rockdaboot requested a review from a team as a code owner March 12, 2024 14:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cauemarcondes cauemarcondes enabled auto-merge (squash) March 12, 2024 14:49
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 400.6KB 400.6KB +15.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rockdaboot

@cauemarcondes cauemarcondes merged commit b91962e into elastic:main Mar 12, 2024
17 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 12, 2024
Fix a regression introduced in
elastic#178481

(cherry picked from commit b91962e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 12, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [Fix flamegraph regression
(#178511)](#178511)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tim
Rühsen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-03-12T16:41:53Z","message":"Fix
flamegraph regression (#178511)\n\nFix a regression introduced
in\r\nhttps://github.com//pull/178481","sha":"b91962e01827060a4fe95512663258dd42eb4b58","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:obs-ux-infra_services","v8.13.0","v8.14.0"],"title":"Fix
flamegraph
regression","number":178511,"url":"https://github.com/elastic/kibana/pull/178511","mergeCommit":{"message":"Fix
flamegraph regression (#178511)\n\nFix a regression introduced
in\r\nhttps://github.com//pull/178481","sha":"b91962e01827060a4fe95512663258dd42eb4b58"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178511","number":178511,"mergeCommit":{"message":"Fix
flamegraph regression (#178511)\n\nFix a regression introduced
in\r\nhttps://github.com//pull/178481","sha":"b91962e01827060a4fe95512663258dd42eb4b58"}}]}]
BACKPORT-->

Co-authored-by: Tim Rühsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.13.0 v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants