-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Avoid subobject/scalar mapping conflicts by setting subobjects: false on custom integrations #178397
[Fleet] Avoid subobject/scalar mapping conflicts by setting subobjects: false on custom integrations #178397
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/fleet (Team:Fleet) |
@felixbarny is it fair to call this a "feature" in the release notes? What would be a good doc page to link to? Simply https://www.elastic.co/guide/en/elasticsearch/reference/current/subobjects.html ? |
Yes, I think so. But I would not frame it as "setting subobjects to false" but talk more about the impact this has i.e. avoiding object/scalar conflicts.
Yes, I think so. Note that on the master branch (https://www.elastic.co/guide/en/elasticsearch/reference/master/subobjects.html), this contains more info about auto flattening. This will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…/kibana into subobjects-custom-integrations
Updated the description |
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
To update your PR or re-run it, just comment with: cc @flash1293 |
In case of a property in indexed documents is sometimes a scalar value (e.g. a number or string) and sometimes an object with sub-properties, mapping conflicts will prevent data from being indexed properly.
The
subobjects
mapping property makes sure no additional subobject mappings will be defined during runtime. You can learn more here: https://www.elastic.co/guide/en/elasticsearch/reference/current/subobjects.htmlThis PR sets
subobjects: false
on logs data streams for custom integrations to avoid. This only affects newly created integrations.The setting is set via the
@package
component template.This only requires a small change in the generated datastream entry, as
index_template.mappings
are already spread into the index config of the component template:kibana/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/install.ts
Line 380 in c98ee2f