Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Wrap infra content in RedirectAppLinks #177747

Conversation

jennypavlova
Copy link
Member

Closes #177056

Summary

This PR adds RedirectAppLinks wrapper to the infra content and removes it from the links using it. The links that are changed:

  • Asset Details (page/flyout)
    • Show all: APM and Alerts links
    • Links to Alerts
    • Links to services (also empty content) / Services tooltip / Single service link
  • Logs links (Asset Details page/flyout and hosts view) Open in Logs
  • Anomaly Detection: Start Trial link

Testing

  • Test for regressions: All links should navigate to different apps without page reload (same behavior as before)
test_links_without_alerts_services.mov
test_links_with_services_and_alerts.mov
  • ⚠️ Ignore the logs error - my config with the cluster was wrong when I recorded that
test_single_service_link.mov

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Feb 23, 2024
@jennypavlova jennypavlova self-assigned this Feb 23, 2024
@jennypavlova jennypavlova requested review from a team as code owners February 23, 2024 18:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... thanks for improving it

Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennypavlova jennypavlova enabled auto-merge (squash) March 4, 2024 14:32
@jennypavlova jennypavlova merged commit 2e808ac into elastic:main Mar 4, 2024
20 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.4MB 1.4MB -2.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 100.6KB 102.6KB +2.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jennypavlova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Wrap infra app in RedirectAppLinks
7 participants