Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability onboarding] Applying regex globally #177719

Merged
merged 4 commits into from
Mar 11, 2024
Merged

[Observability onboarding] Applying regex globally #177719

merged 4 commits into from
Mar 11, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Feb 23, 2024

Closes #177704.

@yngrdyn yngrdyn requested a review from a team as a code owner February 23, 2024 14:26
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the release_note:skip Skip the PR/issue when compiling release notes label Feb 23, 2024
@yngrdyn yngrdyn enabled auto-merge (squash) March 6, 2024 10:34
@yngrdyn yngrdyn disabled auto-merge March 6, 2024 10:34
tonyghiani
tonyghiani approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yngrdyn yngrdyn enabled auto-merge (squash) March 11, 2024 09:37
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 241.8KB 241.8KB -20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit d744b69 into elastic:main Mar 11, 2024
17 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Mar 11, 2024
@gbamparop gbamparop added the Team:obs-ux-logs Observability Logs User Experience Team label Apr 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyghiani tonyghiani tonyghiani approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Observability Onboarding] [Security issue] Incomplete string escaping or encoding
7 participants
@yngrdyn @apmmachine @kibana-ci @elasticmachine @tonyghiani @gbamparop @kibanamachine