Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset quality] using common data types for timeRange #177630

Merged
merged 3 commits into from
Feb 23, 2024
Merged

[Dataset quality] using common data types for timeRange #177630

merged 3 commits into from
Feb 23, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Feb 22, 2024

This is a follow up PR of #177000.

Changes

  • Replace custom types for timeRangeConfig in dataset quality with common types coming from data plugin.

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes Feature:Dataset Health labels Feb 22, 2024
@yngrdyn yngrdyn self-assigned this Feb 22, 2024
@yngrdyn yngrdyn requested a review from a team as a code owner February 22, 2024 17:39
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@weltenwort weltenwort self-requested a review February 22, 2024 18:48
@weltenwort
Copy link
Member

/oblt-deploy

@yngrdyn yngrdyn force-pushed the use-data-timefilter-types branch 2 times, most recently from 7707830 to 761dc86 Compare February 23, 2024 12:02
@yngrdyn yngrdyn force-pushed the use-data-timefilter-types branch from 761dc86 to b658cd4 Compare February 23, 2024 13:30
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 141.9KB 141.8KB -24.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityLogsExplorer 14.3KB 14.3KB -6.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

weltenwort
weltenwort reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Normally we'd have to increment the url schema version for such a change. But since this page is not exposed anywhere yet I think we can get by without it this time.

@yngrdyn yngrdyn merged commit 623177f into elastic:main Feb 23, 2024
18 checks passed
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Feb 23, 2024
semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
@yngrdyn @semd
[Dataset quality] using common data types for timeRange (elastic#177630)
0519539 
This is a [follow
up](elastic#177000 (comment))
PR of elastic#177000.

## Changes
- Replace custom types for `timeRangeConfig` in dataset quality with
common types coming from data plugin.
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
@yngrdyn @fkanout
[Dataset quality] using common data types for timeRange (elastic#177630)
e59cbcd 
This is a [follow
up](elastic#177000 (comment))
PR of elastic#177000.

## Changes
- Replace custom types for `timeRangeConfig` in dataset quality with
common types coming from data plugin.
@yngrdyn yngrdyn added the Team:obs-ux-logs Observability Logs User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees

@yngrdyn yngrdyn

Labels
backport:skip This commit does not require backporting Feature:Dataset Health release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yngrdyn @apmmachine @weltenwort @kibana-ci @elasticmachine @kibanamachine