-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix loading fields for transform destination index template #177608
[Fleet] Fix loading fields for transform destination index template #177608
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
a51a157
to
11d3f09
Compare
'latest_ioc' | ||
); | ||
|
||
expect(fields).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisberkhout Can you confirm it's the expected behaviour given the two fields files above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's right.
/ci |
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nchaulet |
Description
Resolve #175331
We have currently two different approach to build mappings for template and datastreams;
That PR fix that by using processing fields for transform destination index index template the same way we do for datastream index template.
How to test
I added some unit test, to cover the shallow mapping issue.
You can manually try to add some packages with transform and check the mappings looks correct.
I tried a few package myself (
endpoint
,ti_opencti
and mappings looks correct)