Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Fix loading fields for transform destination index template #177608

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Feb 22, 2024

Description

Resolve #175331

We have currently two different approach to build mappings for template and datastreams;

That PR fix that by using processing fields for transform destination index index template the same way we do for datastream index template.

How to test

I added some unit test, to cover the shallow mapping issue.

You can manually try to add some packages with transform and check the mappings looks correct.
I tried a few package myself (endpoint, ti_opencti and mappings looks correct)

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Feb 22, 2024
@nchaulet nchaulet self-assigned this Feb 22, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@nchaulet nchaulet changed the title [Fleet] Fix loading fields for transform destination index template @nchaulet [Fleet] Fix loading fields for transform destination index template Feb 22, 2024
@nchaulet nchaulet force-pushed the feature-fix-transform-loading-fields branch from a51a157 to 11d3f09 Compare February 22, 2024 16:29
'latest_ioc'
);

expect(fields).toMatchInlineSnapshot(`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisberkhout Can you confirm it's the expected behaviour given the two fields files above

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right.

@nchaulet
Copy link
Member Author

/ci

@nchaulet nchaulet marked this pull request as ready for review February 22, 2024 19:20
@nchaulet nchaulet requested a review from a team as a code owner February 22, 2024 19:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit c98ee2f into elastic:main Feb 23, 2024
20 checks passed
@nchaulet nchaulet deleted the feature-fix-transform-loading-fields branch February 23, 2024 14:50
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Transform mappings lost in shallow merge
7 participants