Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip flacky cellActions test #177577

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

semd
Copy link
Contributor

@semd semd commented Feb 22, 2024

Summary

part of: #161874
Fixes hover actions flaky cypress test.

Flaky test runner execution after changes:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5293

@semd semd self-assigned this Feb 22, 2024
@semd semd marked this pull request as ready for review February 23, 2024 15:58
@semd semd requested a review from a team as a code owner February 23, 2024 15:58
@semd semd added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore v8.13.0 labels Feb 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@@ -26,7 +26,7 @@ export const openHoverActions = () => {
};

export const mouseoverOnToOverflowItem = () => {
cy.get(OVERFLOW_ITEM).first().realHover();
cy.get(OVERFLOW_ITEM).first().trigger('mouseover');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change that fixed the flakiness.

@semd
Copy link
Contributor Author

semd commented Feb 23, 2024

@elasticmachine merge upstream

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit cd6bc5e into elastic:main Mar 4, 2024
38 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2024
## Summary

part of: elastic#161874
Fixes hover actions flaky cypress test.

Flaky test runner execution after changes:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5293

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Angela Chuang <[email protected]>
(cherry picked from commit cd6bc5e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@semd semd removed the v8.13.0 label Mar 4, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Mar 4, 2024
semd added a commit to semd/kibana that referenced this pull request Mar 4, 2024
## Summary

part of: elastic#161874
Fixes hover actions flaky cypress test. 

Flaky test runner execution after changes:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5293

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Angela Chuang <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

part of: elastic#161874
Fixes hover actions flaky cypress test. 

Flaky test runner execution after changes:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5293

---------

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Angela Chuang <[email protected]>
semd added a commit that referenced this pull request Mar 6, 2024
## Summary

closes: #165692
part of: #161874

Hover action flakiness was fixed here
#177577

This PR unskips the test and enables it for serverless execution.

Flaky test runner execution after changes:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants