Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Moving] Move Observability App folders into /x-pack/observability_solution #177437

Merged

Conversation

CoenWarmer
Copy link
Contributor

@CoenWarmer CoenWarmer commented Feb 21, 2024

Summary

This PR is part of the initiative to consolidate Observability plugins into x-pack/plugins/observability_solution.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the Observability Office Hours meeting at the end of 2023.

Related PRs:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Feb 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@bollinic bollinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for onboarding

CoenWarmer added a commit that referenced this pull request Feb 22, 2024
…177453)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](#177433)
- [ ] [Move Data Quality](#177456)
- [ ] [Move Exploratory
View](#177440)
- [ ] [Move Infra](#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](#177427)
- [ ] [Move Observability
App](#177437)
- [ ] [Move Observability
Onboarding](#177458)
- [ ] [Move Observability
Shared](#177463)
- [ ] [Move Profiling](#177453)
<-- you are here
- [ ] [Move Synthetics](#177464) 
- [ ] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
@CoenWarmer
Copy link
Contributor Author

CoenWarmer commented Feb 23, 2024

@CoenWarmer Not directly related to this PR, but you could please remove this line CoenWarmer/kibana@feat/move-obs-plugins-observability/.eslintrc.js#L918? It is again defined on line 920.

Done!

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any changes to the UI text, so this looks good from the docs perspective.

CoenWarmer added a commit that referenced this pull request Feb 23, 2024
…lity_solution/` (#177433)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](#177433) <-- you
are here
- [x] [Move Data Quality](#177456)
- [x] [Move Exploratory
View](#177440)
- [ ] [Move Infra](#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](#177427)
- [ ] [Move Observability
App](#177437)
- [x] [Move Observability
Onboarding](#177458)
- [x] [Move Observability
Shared](#177463)
- [x] [Move Profiling](#177453)
- [x] [Move Synthetics](#177464) 
- [x] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
Copy link
Contributor

@ryankeairns ryankeairns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved scss files

@CoenWarmer CoenWarmer force-pushed the feat/move-obs-plugins-observability branch from 9a7403b to 566a722 Compare February 24, 2024 10:43
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / RegisteredAttachmentsPropertyActions renders the correct number of actions

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 658.1KB 658.1KB -10.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@CoenWarmer CoenWarmer merged commit 4c8d8ef into elastic:main Feb 24, 2024
37 checks passed
@CoenWarmer CoenWarmer deleted the feat/move-obs-plugins-observability branch February 24, 2024 12:49
@kibanamachine kibanamachine added v8.14.0 backport:skip This commit does not require backporting labels Feb 24, 2024
semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
…lity_solution/` (elastic#177433)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433) <-- you
are here
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
semd pushed a commit to semd/kibana that referenced this pull request Mar 4, 2024
…olution` (elastic#177437)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [ ] [Move Logs Shared](elastic#177735)
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437) <-- you are here
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…lastic#177453)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [ ] [Move Data Quality](elastic#177456)
- [ ] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [ ] [Move Observability
Onboarding](elastic#177458)
- [ ] [Move Observability
Shared](elastic#177463)
- [ ] [Move Profiling](elastic#177453)
<-- you are here
- [ ] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…lution` (elastic#177440)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [ ] [Move Data Quality](elastic#177456)
- [ ] [Move Exploratory
View](elastic#177440) <-- you are here
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [ ] [Move Observability
Onboarding](elastic#177458)
- [ ] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [ ] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…_solution` (elastic#177463)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [ ] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [ ] [Move Observability
Onboarding](elastic#177458)
- [ ] [Move Observability
Shared](elastic#177463) <-- you are here
- [x] [Move Profiling](elastic#177453)
- [ ] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…tion` (elastic#177456)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [ ] [Move Data Quality](elastic#177456)
<-- you are here
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [ ] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [ ] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Yngrid Coello <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…lity_solution` (elastic#177458)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [ ] [Move Observability
Onboarding](elastic#177458) <-- you are
here
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [ ] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…astic#177466)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [ ] [Move Uptime](elastic#177466) <--
you are here
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…lity_solution/` (elastic#177433)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [ ] [Move APM ](elastic#177433) <-- you
are here
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437)
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
…olution` (elastic#177437)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This PR is strictly a move and an update in references.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](elastic#177433)
- [x] [Move Data Quality](elastic#177456)
- [x] [Move Exploratory
View](elastic#177440)
- [ ] [Move Infra](elastic#177443)
- [X] Move Logs Explorer
- [ ] [Move Logs Shared](elastic#177735)
- [x] [Move Observability AI
Assistant](elastic#177427)
- [ ] [Move Observability
App](elastic#177437) <-- you are here
- [x] [Move Observability
Onboarding](elastic#177458)
- [x] [Move Observability
Shared](elastic#177463)
- [x] [Move Profiling](elastic#177453)
- [x] [Move Synthetics](elastic#177464) 
- [x] [Move Uptime](elastic#177466)
- [x] [Move UX](elastic#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
CoenWarmer added a commit that referenced this pull request Mar 5, 2024
#177735)

## Summary

This PR is part of the initiative to consolidate Observability plugins
into `x-pack/plugins/observability_solution`.

This was discussed and agreed upon with the Observability org in the
Observability Office Hours meeting at the end of 2023.

## Related PRs:
- [x] [Move APM ](#177433)
- [x] [Move Data Quality](#177456)
- [x] [Move Exploratory
View](#177440)
- [x] [Move Infra](#177443)
- [X] Move Logs Explorer
- [x] [Move Logs Shared](#177735)
<-- you are here
- [x] [Move Observability AI
Assistant](#177427)
- [x] [Move Observability
App](#177437)
- [x] [Move Observability
Onboarding](#177458)
- [x] [Move Observability
Shared](#177463)
- [x] [Move Profiling](#177453)
- [x] [Move Synthetics](#177464) 
- [x] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
CoenWarmer added a commit that referenced this pull request Mar 14, 2024
…emetry and i18n ESLint rules for all Obs plugins (#177785)

## Summary

This does two things:

* Moves to Emotion CSS from .scss files
* Enables Telemetry and i18n ESLint rules for all Observability apps 

## Why?

**Move to Emotion CSS**
There were four .scss files total in the 17 Observability plugins. Two
of them were empty. The remaining two had one class each. By removing
the two empty files and moving to Emotion, we can remove the lines
pertaining to .scss files in the CODEOWNERS file.

**Enabling Telemetry and i18n ESLint rules for all Observability apps**
One of the reasons for consolidating Obs apps into one folder was to
create a more consistent development experience across apps in the
Observability org.

By changing the eslint rule config to enable the
[Telemetry](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-telemetry)
and
[i18n](https://github.com/elastic/kibana/tree/main/packages/kbn-eslint-plugin-i18n)
ESLint rules on all `.ts` and `tsx` files in `observability_solution`,
we enable the rule for 5 apps that did not have them enabled before and
we ensure that the rule will immediately be enabled on new Observability
applications at the moment of creation.

## Related PRs:
- [x] [Move APM ](#177433)
- [x] [Move Data Quality](#177456)
- [x] [Move Exploratory
View](#177440)
- [x] [Move Infra](#177443)
- [X] Move Logs Explorer
- [x] [Move Logs Shared](#177735)
- [x] [Move Observability AI
Assistant](#177427)
- [x] [Move Observability
App](#177437)
- [x] [Move Observability
Onboarding](#177458)
- [x] [Move Observability
Shared](#177463)
- [x] [Move Profiling](#177453)
- [x] [Move Synthetics](#177464) 
- [x] [Move Uptime](#177466)
- [x] [Move UX](#177470)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.