[Discover] Show loading indicator when DataView is switched #177240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
1 similar comment
|
/ci |
…ange-data-view-behavior
…ange-data-view-behavior
|
/ci |
kertal
changed the title
kertal
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
approved these changes
Feb 23, 2024
src/plugins/discover/public/application/main/hooks/utils/change_data_view.test.ts
Outdated
Show resolved
Hide resolved
jughosta
reviewed
Feb 23, 2024
src/plugins/discover/public/application/main/services/discover_internal_state_container.ts
Outdated
Show resolved
Hide resolved
…e_data_view.test.ts Co-authored-by: Julia Rechkunova <[email protected]>
💚 Build Succeeded
Metrics [docs]Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: cc @kertal |
kibanamachine
added
v8.14.0
backport:skip
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Mar 4, 2024
…177240) Interating a loading indicator after 300ms when a data view is being switched and its field caps request takes longer e.g. because it hasn't been cached before. This is providing a better visual feedback when there's a loading process in progress. For faster cached requests the loading indicate isn't displayed, preventing a flickered rendering in this case. Co-authored-by: Julia Rechkunova <[email protected]>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…177240) Interating a loading indicator after 300ms when a data view is being switched and its field caps request takes longer e.g. because it hasn't been cached before. This is providing a better visual feedback when there's a loading process in progress. For faster cached requests the loading indicate isn't displayed, preventing a flickered rendering in this case. Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #167706
This PR is showing an EuiProgres bar after 300ms when a data view is being switched and its field caps request takes longer e.g. because it hasn't been cached before. This is providing a better visual feedback indicating the there's a loading process in progress. For faster / cached requests the loading indicate isn't displayed, preventing a flickered rendering in this case.
Here's an example when initially loading a larger CCS data view
Kapture.2024-02-23.at.10.34.41.mp4
Checklist