Move ng_mock wrapper to test_utils #17712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
|
Jenkins, test this - seems like an unrelated Discover failure |
💔 Build Failed |
💚 Build Succeeded |
jbudz
approved these changes
Apr 16, 2018
spalger
reviewed
Apr 16, 2018
| @@ -18,7 +18,7 @@ module.exports = function getWebpackConfig(source, projectRoot, config) { | |||
| 'moment-timezone$': fromKibana('webpackShims/moment-timezone'), | |||
|
|
|||
| // Dev defaults for test bundle https://github.com/elastic/kibana/blob/6998f074542e8c7b32955db159d15661aca253d7/src/core_plugins/tests_bundle/index.js#L73-L78 | |||
| ng_mock$: fromKibana('src/core_plugins/dev_mode/public/ng_mock'), | |||
| ng_mock$: fromKibana('src/test_utils/public/ng_mock'), | |||
timroes
added a commit
to timroes/kibana
that referenced
this pull request
Apr 17, 2018
timroes
added a commit
that referenced
this pull request
Apr 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of Inspector (#16387) we'll be able to remove the
dev_modecore plugin, since there isn't much more in it, than the old spy panel debug spy mode. The only file that would be left in the plugin is theng_mockwrapper we use.After talking to @spalger I moved this to
test_utilsinstead, so that we can remove thedev_modeplugin once I am done with the Inspector. Wanted to have this in a separate PR, to not clutter the inspector PR more.