Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom threshold] Add group by filters to the custom threshold view in app URL #177016

Merged
merged 5 commits into from
Feb 22, 2024
Merged

[Custom threshold] Add group by filters to the custom threshold view in app URL #177016

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19b649d
Add group by filters to the csutom threshold view in app URL
maryam-saeidi Feb 15, 2024
9002111
Merge branch 'main' into 173713-include-group-by
maryam-saeidi Feb 15, 2024
9383d06
Fix test
maryam-saeidi Feb 15, 2024
58da157
Merge branch 'main' into 173713-include-group-by
maryam-saeidi Feb 19, 2024
8a72a82
Merge branch 'main' into 173713-include-group-by
maryam-saeidi Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/field_maps/legacy_experimental_field_map.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,12 @@ export const legacyExperimentalFieldMap = {
},
[ALERT_GROUP_FIELD]: {
type: 'keyword',
array: false,
array: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymao1 Is it safe to fix this field mapping? array: false was wrong and it should have been true.

required: false,
},
[ALERT_GROUP_VALUE]: {
type: 'keyword',
array: false,
array: true,
required: false,
},
} as const;
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_apm_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ const ObservabilityApmAlertOptional = rt.partial({
'kibana.alert.evaluation.values': schemaStringOrNumberArray,
'kibana.alert.group': rt.array(
rt.partial({
field: schemaString,
value: schemaString,
field: schemaStringArray,
value: schemaStringArray,
})
),
labels: schemaUnknown,
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_logs_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ const ObservabilityLogsAlertOptional = rt.partial({
'kibana.alert.evaluation.values': schemaStringOrNumberArray,
'kibana.alert.group': rt.array(
rt.partial({
field: schemaString,
value: schemaString,
field: schemaStringArray,
value: schemaStringArray,
})
),
});
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_metrics_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ const ObservabilityMetricsAlertOptional = rt.partial({
'kibana.alert.evaluation.values': schemaStringOrNumberArray,
'kibana.alert.group': rt.array(
rt.partial({
field: schemaString,
value: schemaString,
field: schemaStringArray,
value: schemaStringArray,
})
),
});
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_slo_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ const ObservabilitySloAlertOptional = rt.partial({
'kibana.alert.evaluation.values': schemaStringOrNumberArray,
'kibana.alert.group': rt.array(
rt.partial({
field: schemaString,
value: schemaString,
field: schemaStringArray,
value: schemaStringArray,
})
),
'slo.id': schemaString,
Expand Down
4 changes: 2 additions & 2 deletions packages/kbn-alerts-as-data-utils/src/schemas/generated/observability_uptime_schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,8 @@ const ObservabilityUptimeAlertOptional = rt.partial({
'kibana.alert.evaluation.values': schemaStringOrNumberArray,
'kibana.alert.group': rt.array(
rt.partial({
field: schemaString,
value: schemaString,
field: schemaStringArray,
value: schemaStringArray,
})
),
'monitor.id': schemaString,
Expand Down
56 changes: 28 additions & 28 deletions ...plugins/alerting/server/integration_tests/__snapshots__/alert_as_data_fields.test.ts.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading