Refactor toast message by test subj #176889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wayneseymour
added
release_note:skip
This was referenced Feb 14, 2024
|
/ci |
|
Flaky x50 for x-pack/test/cloud_security_posture_functional/config.ts: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5173 |
|
@elasticmachine merge upstream |
dmlemeshko
reviewed
Feb 15, 2024
packages/kbn-ftr-common-functional-ui-services/services/toasts.ts
Outdated
Show resolved
Hide resolved
…mour/kibana into refactor-toastMessageByTestSubj
opauloh
approved these changes
Feb 15, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Refactor `toastMessageByTestSubj` method to two methods, instead of being nested. ## Why We feel that the this method is not ergonomic to our purposes. So, let's simplify it so that our devs can make use of it, easily. This is apart of myriad efforts to clean things up and centralize. Lastly, it's a follow up pr to [[FTR] Refactor toasts svc ](elastic#174222) Note: The flaky runner was [run against the only config that uses these two additional methods, successfully](elastic#176889 (comment)). Resolves elastic#176570 --------- Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Dzmitry Lemechko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
toastMessageByTestSubjmethod to two methods, instead of being nested.Why
We feel that the this method is not ergonomic to our purposes.
So, let's simplify it so that our devs can make use of it, easily.
This is apart of myriad efforts to clean things up and centralize.
Lastly, it's a follow up pr to [FTR] Refactor toasts svc
Note: The flaky runner was run against the only config that uses these two additional methods, successfully.
Resolves #176570