-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(slo): Optimistic updates #176548
fix(slo): Optimistic updates #176548
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/ci |
/ci |
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kdelemme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🌮 Summary
This PR removes the broken optimistic updates we had in our various react query mutations for SLOs, namely useCreateSlo, useUpdateSlo, useResetSlo and useDeleteSlo. We are removing them for a few reasons:
I've also notice usage of a useMutation for a non mutation API (_inspect), therefore I've changed the hook to use a useQuery instead. I had to change how this useMutation was then use in the InspectSlo flyout component.
I've also updated the EquivalentAPIRequest to handle the edit form flow, and show the correct API verb and URI.
🧪 Testing