[CodeEditor] Explicitly call the latest props.onChange
#176296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-editor-stale # Conflicts: # packages/shared-ux/code_editor/impl/code_editor.tsx
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 7, 2024
) ## Summary fix elastic#175684 Refer to the issue elastic#175684 for the problem and reproduction I tested that this fixes the issue using the story from the reproduction elastic#175670 and the URL drilldown's placeholder issue explained in elastic#175684
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
) ## Summary fix elastic#175684 Refer to the issue elastic#175684 for the problem and reproduction I tested that this fixes the issue using the story from the reproduction elastic#175670 and the URL drilldown's placeholder issue explained in elastic#175684
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
) ## Summary fix elastic#175684 Refer to the issue elastic#175684 for the problem and reproduction I tested that this fixes the issue using the story from the reproduction elastic#175670 and the URL drilldown's placeholder issue explained in elastic#175684
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #175684
Refer to the issue #175684 for the problem and reproduction
I tested that this fixes the issue using the story from the reproduction #175670 and the URL drilldown's placeholder issue explained in #175684