[Security Solution][Endpoint] Hide agent types on `Types` filter when on a flyout and other UI changes #176280

ashokaditya · 2024-02-06T10:19:36Z

Summary

For Types filter on a flyout/responder (when a single agent is selected), that shows agent type and action type filter options, it doesn't make sense to allow selecting agent types as there can only be one agent type. This PR fixes that bug by:

Not showing the agent types filter options

Additionally the PR updates

Agent type name to Elastic Defend instead of Endpoint.
Adds Agent type value to expanded output tray.
Uses the correct field for getting host names for sentinel one hosts from sentinel one alerts
Correctly calculates the available filter options in Types filter.

Team consensus

remove agent types from flyout types filter

clip/screenshot (Types filter)

flyout/responder view

history page view

Output sections

Updated Responder header info for Sentinel One host

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

refs elastic/security-team/issues/8336

elasticmachine · 2024-02-06T10:30:33Z

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

gergoabraham

thanks for the fix! 🙌

...s/security_solution/public/management/pages/endpoint_hosts/view/details/endpoint_details.tsx

x-pack/plugins/security_solution/public/management/hooks/use_with_show_responder.tsx

...ty_solution/public/management/components/endpoint_response_actions_list/components/hooks.tsx

caitlinbetz

This makes sense to me, looks good!

We decided to not show agent types for single agent views where selecting agent type doesn't make sense

refs 94eb613

gergoabraham

I like the new approach! ☝️ 💯

thanks for all the modifications, I think this is ready to 🚢

gergoabraham · 2024-02-07T09:10:55Z

...ty_solution/public/management/components/endpoint_response_actions_list/components/hooks.tsx

+  const numFilters = useMemo(
+    () => items.filter((item) => item.key && item.checked !== 'on').length,
+    [items]


nice catch!

x-pack/plugins/security_solution/public/management/hooks/use_with_show_responder.tsx

kibana-ci · 2024-02-07T11:45:09Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 4fb9a80

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #56 / aiops log rate analysis with 'kibana_sample_data_logstsdb' kibana sample data logs displays index details
[job] [logs] FTR Configs #47 / fleet rejects request to create a new fleet server hosts if host url is different from default

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	11.4MB	11.4MB	+372.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	69.9KB	69.9KB	+6.0B

History

💔 Build #191669 failed 7087be8
💔 Build #191602 failed c1e7cb2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

… on a flyout and other UI changes (elastic#176280) ## Summary For `Types` filter on a flyout/responder (when a single agent is selected), that shows agent type and action type filter options, it doesn't make sense to allow selecting agent types as there can only be one agent type. This PR fixes that bug by: 1. Not showing the agent types filter options Additionally the PR updates 1. Agent type name to **Elastic Defend** _instead of Endpoint_. 2. Adds `Agent type` value to expanded output tray. 3. Uses the correct field for getting host names for sentinel one hosts from sentinel one alerts 4. Correctly calculates the available filter options in Types filter. ### Team consensus - [x] remove agent types from flyout types filter ### clip/screenshot (Types filter) #### flyout/responder view ![Screenshot 2024-02-06 at 5 04 38 PM](https://github.com/elastic/kibana/assets/1849116/e0540bcc-cf51-4983-97df-de1561c23930) #### history page view ![Screenshot 2024-02-06 at 5 05 01 PM](https://github.com/elastic/kibana/assets/1849116/27546ece-2327-4a9f-82f6-97f83c5826b9) #### Output sections ![Screenshot 2024-02-06 at 4 40 53 PM](https://github.com/elastic/kibana/assets/1849116/c31ff450-a626-4652-9298-d777af11f057) ![Screenshot 2024-02-06 at 4 41 01 PM](https://github.com/elastic/kibana/assets/1849116/5ba77d8b-d898-4921-8dff-00faf85b5d3f) ### Updated Responder header info for Sentinel One host ![Screenshot 2024-02-06 at 5 07 50 PM](https://github.com/elastic/kibana/assets/1849116/97ea17ba-2f4c-4850-bcac-20c822465b96) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

preselect agent type and disable options flyout

8c6beba

refs elastic/security-team/issues/8336

ashokaditya added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint v8.1.3 labels Feb 6, 2024

ashokaditya self-assigned this Feb 6, 2024

ashokaditya marked this pull request as ready for review February 6, 2024 10:30

ashokaditya requested a review from a team as a code owner February 6, 2024 10:30

ashokaditya requested review from gergoabraham and ferullo February 6, 2024 10:30

ashokaditya requested review from paul-tavares, dasansol92 and caitlinbetz February 6, 2024 10:30

ashokaditya and others added 2 commits February 6, 2024 12:16

fix

bd496dc

Merge branch 'main' into task/dw-agent-type-filters-update

c1e7cb2

gergoabraham reviewed Feb 6, 2024

View reviewed changes

caitlinbetz approved these changes Feb 6, 2024

View reviewed changes

ashokaditya added 2 commits February 6, 2024 16:23

Do not show agent types for flyout/responder view

15f8f70

We decided to not show agent types for single agent views where selecting agent type doesn't make sense

Update agent common name

94eb613

ashokaditya requested a review from a team as a code owner February 6, 2024 15:28

ashokaditya requested a review from gergoabraham February 6, 2024 15:28

add agent type to response output sections

677864c

ashokaditya changed the title ~~[Security Solution][Endpoint] Preselect agent types on Types filter when on a flyout~~ [Security Solution][Endpoint] Hide agent types on Types filter when on a flyout and other UI changes Feb 6, 2024

ashokaditya added 4 commits February 6, 2024 16:51

fix host name info on responder for sentinel one

32b9bd2

show correct number of total filter options

7087be8

update test

eb75e8c

refs 94eb613

update tests

7e95397

gergoabraham approved these changes Feb 7, 2024

View reviewed changes

update test

6622db3

Merge branch 'main' into task/dw-agent-type-filters-update

4fb9a80

dasansol92 approved these changes Feb 7, 2024

View reviewed changes

ashokaditya enabled auto-merge (squash) February 7, 2024 09:46

ashokaditya merged commit 71c06b8 into elastic:main Feb 7, 2024
39 checks passed

kibanamachine added the v8.13.0 label Feb 7, 2024

ashokaditya removed the v8.1.3 label Feb 7, 2024

kibanamachine added the backport:skip This commit does not require backporting label Feb 7, 2024

ashokaditya deleted the task/dw-agent-type-filters-update branch February 7, 2024 11:56

elastic deleted a comment from kibanamachine Feb 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Hide agent types on `Types` filter when on a flyout and other UI changes #176280

[Security Solution][Endpoint] Hide agent types on `Types` filter when on a flyout and other UI changes #176280

ashokaditya commented Feb 6, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Feb 6, 2024

gergoabraham left a comment

caitlinbetz left a comment

gergoabraham left a comment

gergoabraham Feb 7, 2024

kibana-ci commented Feb 7, 2024

[Security Solution][Endpoint] Hide agent types on Types filter when on a flyout and other UI changes #176280

[Security Solution][Endpoint] Hide agent types on Types filter when on a flyout and other UI changes #176280

Conversation

ashokaditya commented Feb 6, 2024 • edited by kibanamachine Loading

Summary

Team consensus

clip/screenshot (Types filter)

flyout/responder view

history page view

Output sections

Updated Responder header info for Sentinel One host

Checklist

elasticmachine commented Feb 6, 2024

gergoabraham left a comment

Choose a reason for hiding this comment

caitlinbetz left a comment

Choose a reason for hiding this comment

gergoabraham left a comment

Choose a reason for hiding this comment

gergoabraham Feb 7, 2024

Choose a reason for hiding this comment

kibana-ci commented Feb 7, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

[Security Solution][Endpoint] Hide agent types on `Types` filter when on a flyout and other UI changes #176280

[Security Solution][Endpoint] Hide agent types on `Types` filter when on a flyout and other UI changes #176280

ashokaditya commented Feb 6, 2024 •

edited by kibanamachine

Loading