[Cases] Fix edit tags flaky tests #175763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
This was
linked to
issues
Jan 29, 2024
adcoelho
reviewed
Jan 29, 2024
|
|
||
| userEvent.type(screen.getByRole('combobox'), `${sampleTags[0]}{enter}`); | ||
| userEvent.type(screen.getByRole('combobox'), `${sampleTags[0]}{enter}`); |
There was a problem hiding this comment.
Suggested change
| userEvent.type(screen.getByRole('combobox'), `${sampleTags[0]}{enter}`); | |
| userEvent.type(await screen.findByRole('combobox'), `${sampleTags[0]}{enter}`); |
adcoelho
reviewed
Jan 29, 2024
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByText('A tag must contain at least one non-space character.')); |
There was a problem hiding this comment.
Suggested change
| expect(screen.getByText('A tag must contain at least one non-space character.')); | |
| expect(await screen.findByText('A tag must contain at least one non-space character.')); |
adcoelho
requested changes
Jan 29, 2024
| expect( | ||
| screen.getByText('The length of the tag is too long. The maximum length is 256 characters.') | ||
| ); | ||
| await waitFor(() => { |
There was a problem hiding this comment.
Is the await waitFor(... still necessary?
There was a problem hiding this comment.
Thanks for catching this. I forgot them. I fixed it in 26389a4 (#175763)
|
|
||
| userEvent.paste(screen.getByRole('combobox'), `${longTag}`); | ||
| userEvent.keyboard('{enter}'); | ||
| userEvent.paste(screen.getByRole('combobox'), `${longTag}`); |
|
|
||
| userEvent.type(screen.getByRole('combobox'), ' {enter}'); | ||
| userEvent.type(screen.getByRole('combobox'), ' {enter}'); |
|
|
||
| userEvent.type(screen.getByRole('combobox'), 'new{enter}'); | ||
| userEvent.type(screen.getByRole('combobox'), 'new{enter}'); |
adcoelho
approved these changes
Jan 29, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @cnasikas |
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Fixes: elastic#175655, elastic#175623, elastic#175622, elastic#175619, elastic#175618 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary Fixes: elastic#175655, elastic#175623, elastic#175622, elastic#175619, elastic#175618 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #175655, #175623, #175622, #175619, #175618
Checklist
Delete any items that are not applicable to this PR.
For maintainers