[data views] implement fallback sha1 hash for fields request #175181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
mattkime
changed the title
mattkime
added
Feature:Data Views
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
mistic
approved these changes
Jan 22, 2024
kertal
reviewed
Jan 22, 2024
package.json
Outdated
| @@ -1459,6 +1460,7 @@ | |||
| "@types/redux-actions": "^2.6.1", | |||
| "@types/redux-logger": "^3.0.8", | |||
| "@types/resolve": "^1.20.1", | |||
| "@types/rusha": "^0.8.3", | |||
There was a problem hiding this comment.
Thx for taking care of this so quickly 👍 QQ: why not using kbn-crypto-browser, it's not sha1 but sha256, which should do the job, and no new dependency would be necessary (and it just this could be used, to simplify the code)
https://github.com/elastic/kibana/blob/4824d9da8c59f03522779d1b41d531f52b255dab/packages/kbn-crypto-browser/README.md#L4-L3
Maybe it would also reduce the size of the async chunk which has a plus of +12.0KB with this PR
There was a problem hiding this comment.
Thanks, that does make more sense!
davismcphee
approved these changes
Jan 22, 2024
src/plugins/data_views/public/data_views/data_views_api_client.ts
Outdated
Show resolved
Hide resolved
… into data_views_fallback_sha1
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @mattkime |
kibanamachine
added
v8.13.0
backport:skip
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…#175181) ## Summary tldr; The implements a fallback sha1 method when using the browser in an insecure context. The data views fields requests cache need uniqueness across users. This has been implemented by hashing the user object into a HTTP header using sha1. Typically we can use the browser's built in crypto objects for this HOWEVER its not available in insecure contexts - https://www.chromium.org/blink/webcrypto/#accessing-it - this PR supplies a sha1 function for insecure contexts. How to test - when running kibana locally, it will run in a secure context via 127.0.0.1 or localhost. It will run in an insecure context at 0.0.0.0. Simply load some sample data and load a data view. follow up to elastic#168910 Screenshot of error resolved by this pr -  --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tldr; The implements a fallback sha1 method when using the browser in an insecure context.
The data views fields requests cache need uniqueness across users. This has been implemented by hashing the user object into a HTTP header using sha1. Typically we can use the browser's built in crypto objects for this HOWEVER its not available in insecure contexts - https://www.chromium.org/blink/webcrypto/#accessing-it - this PR supplies a sha1 function for insecure contexts.
How to test - when running kibana locally, it will run in a secure context via 127.0.0.1 or localhost. It will run in an insecure context at 0.0.0.0. Simply load some sample data and load a data view.
follow up to #168910
Screenshot of error resolved by this pr -
