[Ops] Use vault kv store when on new Buildkite infra #174915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delanni
added
Team:Operations
|
/ci |
|
Pinging @elastic/kibana-operations (Team:Operations) |
Ikuni17
approved these changes
Jan 18, 2024
| @@ -171,15 +171,22 @@ download_artifact() { | |||
| retry 3 1 timeout 3m buildkite-agent artifact download "$@" | |||
| } | |||
|
|
|||
| if [[ "$VAULT_ADDR" == *"secrets.elastic.co"* ]]; then | |||
There was a problem hiding this comment.
Does this need the TODO: remove... comment as well so that we do not forget about it?
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
mistic
pushed a commit
that referenced
this pull request
Jan 22, 2024
…175223) ## Summary In some scenarios, the VAULT_ADDR is not defined, or at least not at the time when `util.sh` is loaded. Follow up to #174915 - fixes: https://buildkite.com/elastic/kibana-agent-packer-cache/builds/539#018d31d6-86bf-4f30-98fc-a82f42d16a4d
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary On the new Buildkite infra, our agents won't have write access to the paths we used to write the deployment information upon deployment. We're allowed to use KV writes if we enable it (https://docs.elastic.dev/ci/using-secrets#using-shared-secrets, enabling PRs below). I've built this in a way that we can enable the feature before the final rollout, and we can clear up the branches once done with the rollout. Cloud deployment works on the old infra as well as the new, tested on this PR and elastic#171317 Enabled by: elastic/ci#2594 & elastic/ci#2553 Part of: elastic/kibana-operations#15 Related: https://elasticco.atlassian.net/browse/ENGPRD-414
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…lastic#175223) ## Summary In some scenarios, the VAULT_ADDR is not defined, or at least not at the time when `util.sh` is loaded. Follow up to elastic#174915 - fixes: https://buildkite.com/elastic/kibana-agent-packer-cache/builds/539#018d31d6-86bf-4f30-98fc-a82f42d16a4d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On the new Buildkite infra, our agents won't have write access to the paths we used to write the deployment information upon deployment.
We're allowed to use KV writes if we enable it (https://docs.elastic.dev/ci/using-secrets#using-shared-secrets, enabling PRs below).
I've built this in a way that we can enable the feature before the final rollout, and we can clear up the branches once done with the rollout.
Cloud deployment works on the old infra as well as the new, tested on this PR and #171317
Enabled by: https://github.com/elastic/ci/pull/2594 & https://github.com/elastic/ci/pull/2553
Part of: https://github.com/elastic/kibana-operations/issues/15
Related: https://elasticco.atlassian.net/browse/ENGPRD-414