Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor SeverityFilterGroup to use EuiSelectable instead of EuiFilterSelectItem #174912

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[Security Solution] Refactor SeverityFilterGroup to use EuiSelectable instead of EuiFilterSelectItem #174912

merged 1 commit into from
Jan 16, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Jan 16, 2024 •
edited
Loading

EuiFilterSelectItem was deprecated by the EUI team

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4879

Summary

Before

After

Checklist

Delete any items that are not applicable to this PR.

@machadoum machadoum self-assigned this Jan 16, 2024
@machadoum machadoum force-pushed the siem-ea-remove-deprecated-component branch from 4a7ea49 to e438bb3 Compare January 16, 2024 13:15
@machadoum machadoum added release_note:skip Skip the PR/issue when compiling release notes Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team labels Jan 16, 2024
@machadoum machadoum marked this pull request as ready for review January 16, 2024 13:40
@machadoum machadoum requested a review from a team as a code owner January 16, 2024 13:40
@machadoum machadoum requested a review from hop-dev January 16, 2024 13:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@machadoum
Refactor SeverityFilterGroup to use EuiSelectable instead of EuiFilte…
a7509a8 
…rSelectItem

EuiFilterSelectItem is deprecated by the EUI team
@machadoum machadoum force-pushed the siem-ea-remove-deprecated-component branch from e438bb3 to a7509a8 Compare January 16, 2024 14:00
hop-dev
hop-dev approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@machadoum machadoum enabled auto-merge (squash) January 16, 2024 14:41
@machadoum machadoum merged commit c7dad26 into elastic:main Jan 16, 2024
39 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.4MB 11.4MB +94.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hop-dev hop-dev hop-dev approved these changes

Assignees

@machadoum machadoum

Labels
backport:skip This commit does not require backporting Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Theme: entity_analytics v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@machadoum @elasticmachine @kibana-ci @hop-dev @kibanamachine