Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Fix editable markdown tests #174755

Merged
merged 4 commits into from
Jan 15, 2024
Merged

[Cases] Fix editable markdown tests #174755

merged 4 commits into from
Jan 15, 2024

Conversation

adcoelho
Copy link
Contributor

@adcoelho adcoelho commented Jan 12, 2024 •
edited by cnasikas
Loading

Fixes #171177
Fixes #171178
Fixes #171179
Fixes #171180
Fixes #171181
Fixes #171182
Fixes #171183
Fixes #171184
Fixes #171185

Summary

Fixes the EditableMarkdown flaky tests.

Successful builds: https://buildkite.com/elastic/kibana-pull-request/builds?branch=adcoelho%3Afix-editable-markdown-tests

@adcoelho adcoelho self-assigned this Jan 12, 2024
@adcoelho adcoelho requested a review from a team as a code owner January 12, 2024 13:41
@adcoelho adcoelho added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Feature:Cases Cases feature v8.13.0 labels Jan 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@adcoelho adcoelho force-pushed the fix-editable-markdown-tests branch from c213b54 to 1e319fe Compare January 12, 2024 14:02
@adcoelho
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @adcoelho

@adcoelho adcoelho merged commit a3edcc3 into elastic:main Jan 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees

@adcoelho adcoelho

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown errors Shows error message and save button disabled if current text is of empty characters Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown errors Shows error message and save button disabled if current text is empty Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown Cancel button click calls only onChangeEditable Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown Does not call onSaveContent if no change from current text
Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown errors Shows error message and save button disabled if current text is too long Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown draft comment Save button click clears session storage Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown draft comment Cancel button click clears session storage Failing test: Jest Tests.x-pack/plugins/cases/public/components/markdown_editor - EditableMarkdown draft comment existing storage key should have session storage value same as draft comment
5 participants
@adcoelho @elasticmachine @kibana-ci @cnasikas @kibanamachine