[SecuritySolution] Unskip fullscreen timeline tests #174593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmonschke
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: cc @janmonschke |
michaelolo24
approved these changes
Jan 11, 2024
kibanamachine
added
v8.13.0
backport:skip
semd
pushed a commit
to semd/kibana
that referenced
this pull request
Jan 12, 2024
## Summary Unskips the fullscreen timeline tests. Looking at the issue described in elastic#172547, it appears that the timeline was somehow not opening correctly in some cases. This flakiness has been removed in elastic#173413, so it should be possible to unskip these tests. In addition to unskipping the tests, an unnecessary task execution was removed and two force clicks were cleaned up. [Flaky test runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4834) (200/200) fixes elastic#172547
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unskips the fullscreen timeline tests.
Looking at the issue described in #172547, it appears that the timeline was somehow not opening correctly in some cases. This flakiness has been removed in #173413, so it should be possible to unskip these tests.
In addition to unskipping the tests, an unnecessary task execution was removed and two force clicks were cleaned up.
Flaky test runner (200/200)
fixes #172547