[Obs AI Assistant] Move esql docs to dir that does not get deleted #174583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miltonhultgren
approved these changes
Jan 10, 2024
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 10, 2024
…ic#174583) any folder called `docs` is automatically deleted when creating a distributable. Rename it to `esql_docs` so this doesn't happen. We need tests, but will tackle that separately. Not sure how to write tests for the distributable. (cherry picked from commit f9c8344)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 10, 2024
…#174583) (#174603) # Backport This will backport the following commits from `main` to `8.12`: - [[Obs AI Assistant] Move esql docs to dir that does not get ... (#174583)](#174583) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-10T13:53:43Z","message":"[Obs AI Assistant] Move esql docs to dir that does not get ... (#174583)\n\nany folder called `docs` is automatically deleted when creating a\r\ndistributable. Rename it to `esql_docs` so this doesn't happen. We need\r\ntests, but will tackle that separately. Not sure how to write tests for\r\nthe distributable.","sha":"f9c83448c94713a227aa62aae223c90db852e6fa","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:cloud-deploy","ci:cloud-persist-deployment","v8.12.0","v8.12.1","v8.13.0"],"title":"[Obs AI Assistant] Move esql docs to dir that does not get deleted","number":174583,"url":"https://github.com/elastic/kibana/pull/174583","mergeCommit":{"message":"[Obs AI Assistant] Move esql docs to dir that does not get ... (#174583)\n\nany folder called `docs` is automatically deleted when creating a\r\ndistributable. Rename it to `esql_docs` so this doesn't happen. We need\r\ntests, but will tackle that separately. Not sure how to write tests for\r\nthe distributable.","sha":"f9c83448c94713a227aa62aae223c90db852e6fa"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174583","number":174583,"mergeCommit":{"message":"[Obs AI Assistant] Move esql docs to dir that does not get ... (#174583)\n\nany folder called `docs` is automatically deleted when creating a\r\ndistributable. Rename it to `esql_docs` so this doesn't happen. We need\r\ntests, but will tackle that separately. Not sure how to write tests for\r\nthe distributable.","sha":"f9c83448c94713a227aa62aae223c90db852e6fa"}}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <[email protected]>
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Jan 11, 2024
…ic#174583) any folder called `docs` is automatically deleted when creating a distributable. Rename it to `esql_docs` so this doesn't happen. We need tests, but will tackle that separately. Not sure how to write tests for the distributable.
This was referenced Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
any folder called
docsis automatically deleted when creating a distributable. Rename it toesql_docsso this doesn't happen. We need tests, but will tackle that separately. Not sure how to write tests for the distributable.