ci: move remaining Cypress tests behind GH label #174523
Conversation
watson
added
release_note:skip
|
/ci |
|
/ci |
|
/ci |
|
@watson maybe we could just use the same config we had before? here is the link to the file before the changes |
|
/ci |
There was a problem hiding this comment.
@watson sorry for getting back to this so late. I not super familiar with how the paths should be done, so I left a few comments to add what the code is referring to.
| /^package.json/, | ||
| /^packages\/kbn-securitysolution-.*/, | ||
| /^x-pack\/plugins\/threat_intelligence/, | ||
| /^x-pack\/packages\/security-solution/, | ||
| /^x-pack\/test\/security_solution_cypress/, |
There was a problem hiding this comment.
/^x-pack\/test\/security_solution_cypress/
should be replaced by
/^x-pack\/test\/threat_intelligence_cypress/
Currently all the Cypress tests haven’t been migrated to the x-pack/test folder are still in the x-pack/plugins/threat_intelligence folder unfortunately.
I had started to migrated things over before the holidays (actually I was trying to merge them within the security_solution_cypress folder directly for simplicity and code reusability) but we had to jump on reducing flakiness instead. Not sure when I’ll have the time to get back to that…
There was a problem hiding this comment.
also, looking at the code, here are a few that I think we should add
other x-pack plugins:
/x-pack\/plugins\/cases//x-pack\/plugins\/timelines//x-pack\/plugins\/triggers_actions_ui//x-pack\/plugins\/rule_registry/
other packages:
/packages\/kbn-es-query//packages\/kbn-securitysolution-io-ts-list-types//packages\/kbn-i18n-react//packages\/kbn-i18n//packages\/shared-ux//packages\/kbn-doc-links//packages\/kbn-securitysolution-io-ts-list-types/
other src plugins:
/src\/plugins\/data//src\/plugins\/kibana_utils//src\/plugins\/inspector//src\/plugins\/data_views//src\/core/
|
@patrykkopycinski I copied over the old paths regexes from as you suggested. I had to change the following line because the file didn't exist (it actually didn't exist in the old code either, so I'm not sure what was going on): -^x-pack\/plugins\/triggers_actions_ui\/public\/application\/context\/actions_connectors_context\.tsx/,
+^x-pack\/plugins\/triggers_actions_ui\/public\/application\/context\/connectors_context\.tsx/,There is a file in that directory with almost the same name ( |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Move the remaining Security Solution Cypress tests behind the GitHub flag `ci:all-cypress-suites`. This is a follow-up to PR elastic#173815. --------- Co-authored-by: Yngrid Coello <[email protected]>
This PR moves the remaining Security Solution Cypress tests behind the GitHub flag
ci:all-cypress-suites. This is a follow-up to #173815.