Refactor: Use uiSettings directly from services prop

[mgiota]

Refactors according to this comment

[apmmachine]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
• /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

[mgiota]

@maryam-saeidi Could you take a look at this one?

[fkanout]

I'm getting an error
Property 'uiSettings' does not exist on type 'Services'.ts

services should have uiSettings in its type

export interface Services {
  timeFilterService: TimefilterContract;
  AlertsSearchBar: (props: AlertsSearchBarProps) => ReactElement<AlertsSearchBarProps>;
  useToasts: () => ToastsStart;
}

[mgiota]

I'm getting an error Property 'uiSettings' does not exist on type 'Services'.ts

services should have uiSettings in its type

export interface Services {
  timeFilterService: TimefilterContract;
  AlertsSearchBar: (props: AlertsSearchBarProps) => ReactElement<AlertsSearchBarProps>;
  useToasts: () => ToastsStart;
}

I am running it locally now. Will take a look. Thanks for checking it out!

[mgiota]

@fkanout I made the change. Could you take a look?

[mgiota]

@fkanout I am putting it back to Draft, since I am getting this error.

[fkanout]

@fkanout I am putting it back to Draft, since I am getting this error.

That is where it would be challenging. I think the services should be injected in the plugin initialization phase.
Thank you, @mgiota, for doing this!

[fkanout]

I mean even if you add the type, the service aka uiSettings should be provided.

[mgiota]

@fkanout I pushed a fix. Above problem is fixed now. I might need to do a few more changes, since ObservabilityAlertSearchBar is used in more places. Checking it now, if more changes are indeed needed

[mgiota]

I applied all changes, so PR is again ready for review.

I verify that original issue still works as expected.

Screen.Recording.2024-01-04.at.10.24.10.mov

[cauemarcondes]

Obs UX LGTM

[elasticmachine]

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

[fkanout]

LGTM. I tested the Alert table on both the Alert and Rule details pages, and it works as expected.

[mgiota]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 2e2b3e2

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
apm	3.1MB	3.1MB	+26.0B
observability	592.4KB	592.4KB	-14.0B
total			+12.0B

History

• 💔 Build #185778 failed 82a6f06

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mgiota