Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.12] Handle content stream errors in report pre-deletion (#173792) #174138

Closed
wants to merge 1 commit into from
Closed

[8.12] Handle content stream errors in report pre-deletion (#173792) #174138

wants to merge 1 commit into from

Conversation

tsullivan
Copy link
Member

Backport

This will backport the following commits from main to 8.12:

Questions ?

Please refer to the Backport tool documentation

@tsullivan
Handle content stream errors in report pre-deletion (elastic#173792)
bf70e08 
Re-addresses elastic#171363

The bug was still evident, especially when using network throttling to
add slight lag to the request turnaround times.

This PR adds more handling of errors that could be thrown slightly prior
to deleting the report document, when we try to clear all chunks of the
report using the content stream.

<details>
<summary>Before</summary>

https://github.com/elastic/kibana/assets/908371/c27fe314-0f93-42b4-8076-99a1e30b8d2f

</details>

<details>
<summary>After</summary>

https://github.com/elastic/kibana/assets/908371/4c1f5edd-73f1-4ca4-a40a-f900ca5f9c78

</details>

### Checklist
- [x] Unit tests

(cherry picked from commit dc813c3)
@tsullivan tsullivan enabled auto-merge (squash) January 2, 2024 23:04
@tsullivan tsullivan closed this Jan 2, 2024
auto-merge was automatically disabled January 2, 2024 23:37

Pull request was closed

@tsullivan
Copy link
Member Author

duplicated #174139

@tsullivan tsullivan mentioned this pull request Jan 2, 2024
Merged
1 task
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tsullivan tsullivan deleted the backport/8.12/pr-173792 branch April 30, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsullivan @kibana-ci