-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SentinelOne] Add technical preview badge to the Host isolation flyout #174123
[SentinelOne] Add technical preview badge to the Host isolation flyout #174123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I left a few comments for your consideration.
}; | ||
}) => ( | ||
<> | ||
<EuiButtonEmpty iconType="arrowLeft" iconSide="left" flush="left" onClick={showAlertDetails}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you are keeping this change even after v8.13 (where we will likely revert this change, since its 8.12 only), correct? if so, then would suggest adding tests for this change, but I'll defer to the alerts/detections team.
...ugins/security_solution/public/timelines/components/side_panel/event_details/translations.ts
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
elastic#174123) ## Summary Add technical preview to the S1 Host isolation flyout <img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 02 35" src="https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306"> <img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 17 58" src="https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb"> (cherry picked from commit 8a443a2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…n flyout (#174123) (#174729) # Backport This will backport the following commits from `main` to `8.12`: - [[SentinelOne] Add technical preview badge to the Host isolation flyout (#174123)](#174123) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Patryk Kopyciński","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-12T02:27:08Z","message":"[SentinelOne] Add technical preview badge to the Host isolation flyout (#174123)\n\n## Summary\r\n\r\nAdd technical preview to the S1 Host isolation flyout\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 02 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306\">\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 17 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb\">","sha":"8a443a2d188a9e9292d84921d48d5137c5ec8490","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v8.12.0","v8.13.0"],"title":"[SentinelOne] Add technical preview badge to the Host isolation flyout","number":174123,"url":"https://github.com/elastic/kibana/pull/174123","mergeCommit":{"message":"[SentinelOne] Add technical preview badge to the Host isolation flyout (#174123)\n\n## Summary\r\n\r\nAdd technical preview to the S1 Host isolation flyout\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 02 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306\">\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 17 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb\">","sha":"8a443a2d188a9e9292d84921d48d5137c5ec8490"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174123","number":174123,"mergeCommit":{"message":"[SentinelOne] Add technical preview badge to the Host isolation flyout (#174123)\n\n## Summary\r\n\r\nAdd technical preview to the S1 Host isolation flyout\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 02 35\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306\">\r\n\r\n<img width=\"2056\" alt=\"Zrzut ekranu 2024-01-2 o 21 17 58\"\r\nsrc=\"https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb\">","sha":"8a443a2d188a9e9292d84921d48d5137c5ec8490"}}]}] BACKPORT--> Co-authored-by: Patryk Kopyciński <[email protected]>
elastic#174123) ## Summary Add technical preview to the S1 Host isolation flyout <img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 02 35" src="https://github.com/elastic/kibana/assets/5188868/813d3a1a-dbc0-4c36-9c43-55613e983306"> <img width="2056" alt="Zrzut ekranu 2024-01-2 o 21 17 58" src="https://github.com/elastic/kibana/assets/5188868/a863f4dd-1d00-4708-8c4b-c7c8c4dbf0cb">
This PR didn't make it into the latest BC for 8.12.0. Updating the labels. |
Summary
Add technical preview to the S1 Host isolation flyout