Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Obs AI Assistant] Add guardrails #174060

Merged
merged 3 commits into from
Jan 2, 2024

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Dec 29, 2023

Add guardrails against function looping (max 3 calls in a completion request) and long function responses (max 4000 tokens).

@dgieselaar dgieselaar added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.12.1 v8.13.0 labels Dec 29, 2023
@dgieselaar dgieselaar requested a review from a team as a code owner December 29, 2023 15:04
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@dgieselaar
Copy link
Member Author

@elasticmachine merge upstream

@dgieselaar dgieselaar enabled auto-merge (squash) January 2, 2024 12:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

auto-merge was automatically disabled January 2, 2024 13:55

Base branch was modified

@dgieselaar dgieselaar merged commit 725a217 into elastic:main Jan 2, 2024
20 checks passed
@dgieselaar dgieselaar deleted the obs-ai-assistant-guardrails branch January 2, 2024 18:40
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2024
Add guardrails against function looping (max 3 calls in a completion
request) and long function responses (max 4000 tokens).

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 725a217)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2024
# Backport

This will backport the following commits from `main` to `8.12`:
- [[Obs AI Assistant] Add guardrails
(#174060)](#174060)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-01-02T18:35:49Z","message":"[Obs
AI Assistant] Add guardrails (#174060)\n\nAdd guardrails against
function looping (max 3 calls in a completion\r\nrequest) and long
function responses (max 4000
tokens).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"725a21727af57b11bdd709966d20f71f9c9be16c","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.12.0","v8.12.1","v8.13.0"],"title":"[Obs
AI Assistant] Add
guardrails","number":174060,"url":"https://github.com/elastic/kibana/pull/174060","mergeCommit":{"message":"[Obs
AI Assistant] Add guardrails (#174060)\n\nAdd guardrails against
function looping (max 3 calls in a completion\r\nrequest) and long
function responses (max 4000
tokens).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"725a21727af57b11bdd709966d20f71f9c9be16c"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","branchLabelMappingKey":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/174060","number":174060,"mergeCommit":{"message":"[Obs
AI Assistant] Add guardrails (#174060)\n\nAdd guardrails against
function looping (max 3 calls in a completion\r\nrequest) and long
function responses (max 4000
tokens).\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<[email protected]>","sha":"725a21727af57b11bdd709966d20f71f9c9be16c"}}]}]
BACKPORT-->

Co-authored-by: Dario Gieselaar <[email protected]>
jloleysens added a commit that referenced this pull request Jan 4, 2024
* main: (4129 commits)
  [Logs Explorer] Change the default link for "Discover" in the serverless nav (#173420)
  [Fleet] fix unhandled error in agent details when components are missing (#174152)
  [Obs UX] Unskip transaction duration alerts test (#174069)
  [Fleet] Fix keep policies up to date after package install (#174093)
  [Profiling] Stack traces embeddable (#173905)
  [main] Sync bundled packages with Package Storage (#174115)
  [SLO Form] Refactor to use kibana data view component (#173513)
  [Obs UX] Unskip APM Service Inventory Journey (#173510)
  [Obs UX] Unskip preview_chart_error_count test (#173624)
  [api-docs] 2024-01-03 Daily api_docs build (#174142)
  Update babel runtime helpers (#171745)
  Handle content stream errors in report pre-deletion (#173792)
  [Cloud Posture] [Quick wins] Enable edit DataView on the Misconfigurations Findings Table (#173870)
  [ftr] abort retry on invalid webdriver session (#174092)
  Upgrade openai to 4.24.1 (#173934)
  chore(NA): bump node into v20 (#173461)
  [Security Solution][Endpoint] Fix index name pattern in SentinelOne dev. script (#174105)
  fix versions.json
  [Obs AI Assistant] Add guardrails (#174060)
  [ML] Transforms: Refactor validators and add unit tests. (#173736)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.12.1 v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants