[Search] Return empty array when checking api keys for unauthorized user #173823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphilipse
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
kderusso
approved these changes
Dec 21, 2023
| // Unfortunately the error response is not structured enough for us to filter those | ||
| // Always returning an empty array should also be fine, and deals with transient errors | ||
|
|
||
| return response.ok({ body: { api_keys: [] } }); |
There was a problem hiding this comment.
This could be a little misleading if they don't have permissions and are say, using API keys elsewhere. But I think it's an OK workaround for now. Thanks for fixing!
There was a problem hiding this comment.
Yeah it's not ideal. Thankfully security is working on a few utilities we can lean on going forward.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2023
…ser (elastic#173823) ## Summary Instead of returning an obnoxious error on every Search page when fetching an unauthorized user's API keys, we just return an empty array. (cherry picked from commit 1a0dcf6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2023
…rized user (#173823) (#173836) # Backport This will backport the following commits from `main` to `8.12`: - [[Search] Return empty array when checking api keys for unauthorized user (#173823)](#173823) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-21T13:58:25Z","message":"[Search] Return empty array when checking api keys for unauthorized user (#173823)\n\n## Summary\r\n\r\nInstead of returning an obnoxious error on every Search page when\r\nfetching an unauthorized user's API keys, we just return an empty array.","sha":"1a0dcf60fc3f2a8d498ae68f92db53a8de7fd112","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.12.0","v8.13.0"],"number":173823,"url":"https://github.com/elastic/kibana/pull/173823","mergeCommit":{"message":"[Search] Return empty array when checking api keys for unauthorized user (#173823)\n\n## Summary\r\n\r\nInstead of returning an obnoxious error on every Search page when\r\nfetching an unauthorized user's API keys, we just return an empty array.","sha":"1a0dcf60fc3f2a8d498ae68f92db53a8de7fd112"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173823","number":173823,"mergeCommit":{"message":"[Search] Return empty array when checking api keys for unauthorized user (#173823)\n\n## Summary\r\n\r\nInstead of returning an obnoxious error on every Search page when\r\nfetching an unauthorized user's API keys, we just return an empty array.","sha":"1a0dcf60fc3f2a8d498ae68f92db53a8de7fd112"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of returning an obnoxious error on every Search page when fetching an unauthorized user's API keys, we just return an empty array.