Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLOs] Configuration inspect api and flyout #173723

Merged
merged 7 commits into from
Jan 3, 2024
Merged

[SLOs] Configuration inspect api and flyout #173723

merged 7 commits into from
Jan 3, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Dec 20, 2023 •
edited
Loading

Summary

It will show all the associated configs at one place in json form, configuration, ingest pipeline config, roll up transform and summary transform config !!

Motivation is to understand things while onboarding devs to slo and during normal development.

inspect.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31
Copy link
Contributor Author

/ci

@shahzad31 shahzad31 marked this pull request as ready for review December 20, 2023 17:27
@shahzad31 shahzad31 requested review from a team as code owners December 20, 2023 17:27
@shahzad31 shahzad31 added the release_note:skip Skip the PR/issue when compiling release notes label Dec 20, 2023
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

ElenaStoeva
ElenaStoeva approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingest pipelines changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 574 577 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
ingestPipelines 0 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 588.3KB 593.2KB +4.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ingestPipelines 13.9KB 14.0KB +126.0B
observability 100.6KB 100.8KB +145.0B
total +271.0B
Unknown metric groups

API count

id before after diff
ingestPipelines 0 4 +4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mgiota mgiota self-requested a review January 3, 2024 14:33
mgiota
mgiota reviewed Jan 3, 2024
View reviewed changes
x-pack/plugins/observability/server/routes/slo/route.ts
@@ -114,6 +114,42 @@ const createSLORoute = createObservabilityServerRoute({
},
});

const inspectSLORoute = createObservabilityServerRoute({
endpoint: 'POST /internal/api/observability/slos/_inspect 2023-10-31',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzad31 Out of curiosity, I have seen this 2023-10-31 in the other routes as well and I wanted to ask what is it about (my guess is api versioning?) and how do we know which date to add?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a kibana API version, for now that's the only version allowed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ It's definitely an api versioning thing but I was on maternity leave when this was fully implemented and I'd like to understand it.

mgiota
mgiota approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it LGTM!

I have one question. We show the SLO Inspect button on the Edit SLO detail page. Does it make sense to show it on the View SLO detail page as well?

@shahzad31
Copy link
Contributor Author

I tested it and it LGTM!

I have one question. We show the SLO Inspect button on the Edit SLO detail page. Does it make sense to show it on the View SLO detail page as well?

We can probably add it in a follow up in cards view and details view.

@shahzad31 shahzad31 merged commit 9dc9d8f into elastic:main Jan 3, 2024
19 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Jan 3, 2024
@shahzad31 shahzad31 deleted the inspect-view-api branch January 3, 2024 16:40
nreese pushed a commit to nreese/kibana that referenced this pull request Jan 4, 2024
@shahzad31 @nreese
[SLOs] Configuration inspect api and flyout (elastic#173723)
aef1174 
## Summary

It will show all the associated configs at one place in json form,
configuration, ingest pipeline config, roll up transform and summary
transform config !!

Motivation is to understand things while onboarding devs to slo and
during normal development.



https://github.com/elastic/kibana/assets/3505601/a22ad292-ba59-4145-989e-80803b6a1e3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiqueclarke dominiqueclarke dominiqueclarke left review comments

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@mgiota mgiota mgiota approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shahzad31 @apmmachine @elasticmachine @kibana-ci @pgayvallet @mgiota @dominiqueclarke @ElenaStoeva @kibanamachine