Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(slo): Add error budget remaining in time unit #173662

Merged
merged 4 commits into from
Jan 3, 2024
Merged

feat(slo): Add error budget remaining in time unit #173662

merged 4 commits into from
Jan 3, 2024

Conversation

kdelemme
Copy link
Contributor

Resolves #166935

✨ Summary

This PR adds the error budget remaining in time unit next to the percentage value for SLO setup with timeslice and calendar aligned.

Desc Screenshot
Without timeslice and calendar aligned image
With timeslice and calendar aligned, remaining budget image
With timeslice and calendar aligned, exhausted budget image

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Feature:SLO Team:obs-ux-management Observability Management User Experience Team v8.13.0 labels Dec 19, 2023
@kdelemme kdelemme self-assigned this Dec 19, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme force-pushed the feat/show-remaining-budget-duration branch from 286901e to dbedad1 Compare December 19, 2023 16:21
@kdelemme kdelemme marked this pull request as ready for review December 19, 2023 16:30
@kdelemme kdelemme requested a review from a team as a code owner December 19, 2023 16:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@simianhacker simianhacker self-requested a review December 19, 2023 18:49
simianhacker
simianhacker requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about the format... everything else looks good.

x-pack/plugins/observability/public/pages/slo_details/components/error_budget_chart_panel.tsx Outdated Show resolved Hide resolved
@kdelemme kdelemme force-pushed the feat/show-remaining-budget-duration branch from 226c55a to 67c6ca3 Compare December 20, 2023 19:18
simianhacker
simianhacker approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 587.6KB 587.9KB +310.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kdelemme

@kdelemme kdelemme merged commit 52f458c into elastic:main Jan 3, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 3, 2024
@kdelemme kdelemme deleted the feat/show-remaining-budget-duration branch January 3, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees

@kdelemme kdelemme

Labels
backport:skip This commit does not require backporting Feature:SLO release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SLO] Show the error budget remaining in hours for timeslices SLO
6 participants
@kdelemme @apmmachine @elasticmachine @kibana-ci @simianhacker @kibanamachine