Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Removes beta badge from ML alerting rules #173545

Merged
merged 2 commits into from
Dec 19, 2023
Merged

[ML] Removes beta badge from ML alerting rules #173545

merged 2 commits into from
Dec 19, 2023

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Dec 18, 2023 •
edited by kibanamachine
Loading

Summary

  • Removes the beta badge from Anomaly detection and Anomlay detection job health alerting rules.
  • Renames Anomaly detection alerting rule ("Anomaly detection alert" -> "Anomaly detection") for consistency with the other rules in the list

@darnautov darnautov requested a review from a team as a code owner December 18, 2023 16:10
@darnautov darnautov added release_note:enhancement :ml Feature:Anomaly Detection ML anomaly detection Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types labels Dec 18, 2023
@darnautov darnautov added Team:ML Team label for ML (also use :ml) v8.12.0 labels Dec 18, 2023
@darnautov darnautov self-assigned this Dec 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 1870 1869 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.6MB 3.6MB -1.2KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov mentioned this pull request Dec 19, 2023
Merged
peteharverson
peteharverson approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit bf52a13 into elastic:main Dec 19, 2023
48 checks passed
@darnautov darnautov deleted the ml-ad-rule-remove-beta branch December 19, 2023 13:13
@kibanamachine kibanamachine mentioned this pull request Dec 19, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2023
@darnautov
[ML] Remove beta badge from ML alerting rules (elastic#173545)
db235d0 
## Summary

- Removes the beta badge from Anomaly detection and Anomlay detection
job health alerting rules.
- Renames Anomaly detection alerting rule ("Anomaly detection alert" ->
"Anomaly detection") for consistency with the other rules in the list

(cherry picked from commit bf52a13)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2023
@kibanamachine @darnautov
[8.12] [ML] Remove beta badge from ML alerting rules (#173545) (#173623)
49f8243 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[ML] Remove beta badge from ML alerting rules
(#173545)](#173545)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dima
Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-19T13:13:02Z","message":"[ML]
Remove beta badge from ML alerting rules (#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Anomaly
Detection","Feature:Alerting/RuleTypes","Team:ML","v8.12.0","v8.13.0"],"number":173545,"url":"https://github.com/elastic/kibana/pull/173545","mergeCommit":{"message":"[ML]
Remove beta badge from ML alerting rules (#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173545","number":173545,"mergeCommit":{"message":"[ML]
Remove beta badge from ML alerting rules (#173545)\n\n##
Summary\r\n\r\n- Removes the beta badge from Anomaly detection and
Anomlay detection\r\njob health alerting rules.\r\n- Renames Anomaly
detection alerting rule (\"Anomaly detection alert\" ->\r\n\"Anomaly
detection\") for consistency with the other rules in the
list","sha":"bf52a1396dfe0724d826744ddfbf20b16bebe1bb"}}]}] BACKPORT-->

Co-authored-by: Dima Arnautov <[email protected]>
@szabosteve szabosteve changed the title [ML] Remove beta badge from ML alerting rules [ML] Removes beta badge from ML alerting rules Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @peteharverson