-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Co-locate Frontend Entity Analytics Code #173499
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the Threat Hunting Investigations team
@@ -185,6 +185,7 @@ | |||
"@kbn/core-http-common", | |||
"@kbn/search-errors", | |||
"@kbn/stack-connectors-plugin", | |||
"@kbn/elastic-assistant-common" | |||
"@kbn/elastic-assistant-common", | |||
"@kbn/lens-embeddable-utils" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change I've seen in this PR that isn't directly related to code organization, curious what this change does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
It was autogenerated by kibanamachine bot.
2d80600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had one clarifying question!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @machadoum |
Summary
Move all files owned by the Entity Analytics team to
x-pack/plugins/security_solution/public/entity_analytics
Initially, files inside
public/entity_analytics/components
look disorganised because many of them have similar names and do not follow the same conventions.I minimized the PR scope to avoid putting too much of a burden on reviewers.
Changes
entity_analytics
folderentity_analytics
foldertranslation.ts
.Checklist