Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Co-locate Frontend Entity Analytics Code #173499

Merged
merged 13 commits into from
Dec 21, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Dec 18, 2023

Summary

Move all files owned by the Entity Analytics team to x-pack/plugins/security_solution/public/entity_analytics

Initially, files inside public/entity_analytics/components look disorganised because many of them have similar names and do not follow the same conventions.

I minimized the PR scope to avoid putting too much of a burden on reviewers.

Changes

  • Moves files to the entity_analytics folder
  • Updates imports
  • Moves the content of some files to a new file inside the entity_analytics folder
  • Inlines copies that were previously inside translation.ts.
  • No changes to the user experience are expected.

Checklist

@machadoum machadoum added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. AET Team:Entity Analytics Security Entity Analytics Team labels Dec 18, 2023
@machadoum machadoum self-assigned this Dec 18, 2023
@machadoum machadoum marked this pull request as ready for review December 18, 2023 13:35
@machadoum machadoum requested review from a team as code owners December 18, 2023 13:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the Threat Hunting Investigations team

@@ -185,6 +185,7 @@
"@kbn/core-http-common",
"@kbn/search-errors",
"@kbn/stack-connectors-plugin",
"@kbn/elastic-assistant-common"
"@kbn/elastic-assistant-common",
"@kbn/lens-embeddable-utils"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I've seen in this PR that isn't directly related to code organization, curious what this change does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

It was autogenerated by kibanamachine bot.
2d80600

Copy link
Contributor

@jaredburgettelastic jaredburgettelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just had one clarifying question!

@machadoum machadoum enabled auto-merge (squash) December 21, 2023 12:48
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 4839 4835 -4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.3MB 11.3MB -45.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit 306debf into elastic:main Dec 21, 2023
40 checks passed
@kibanamachine kibanamachine added v8.13.0 backport:skip This commit does not require backporting labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture v8.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants