[Discover] Less requests for total hits

[jughosta]

• Addresses [Unified histogram][ES|QL] Extra fetches in specific scenarios #165192

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed
• Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
• Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
• If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
• This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[davismcphee]

@jughosta Thanks for looking into this! One way to check if this is solving the issue would be to update the _request_count tests to expect the correct number of requests for saved searches:

kibana/test/functional/apps/discover/group3/_request_counts.ts

Lines 226 to 246 in 8fd8e9b

	describe('ES|QL mode', () => {
	const type = 'esql';
	beforeEach(async () => {
	await PageObjects.discover.selectTextBaseLang();
	monacoEditor.setCodeEditorValue(
	'from logstash-* | where bytes > 1000 | stats countB = count(bytes)'
	);
	await queryBar.clickQuerySubmitButton();
	await waitForLoadingToFinish();
	});
	getSharedTests({
	type,
	savedSearch: 'esql test',
	query1: 'from logstash-* | where bytes > 1000 | stats countB = count(bytes) ',
	query2: 'from logstash-* | where bytes < 2000 | stats countB = count(bytes) ',
	savedSearchesRequests: 4,
	setQuery: (query) => monacoEditor.setCodeEditorValue(query),
	});
	});

It would also be good to add test cases for any scenario from #165192 that we don't already cover in the current tests before resolving the issue.

[jughosta]

/ci

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 1da94db
• Interpreting CI Failures

Failed CI Steps

• Jest Tests #10
• FTR Configs #9
• FTR Configs #9
• FTR Configs #10
• FTR Configs #10
• FTR Configs #13
• FTR Configs #13
• FTR Configs #17
• FTR Configs #17
• FTR Configs #52
• FTR Configs #52
• FTR Configs #63
• FTR Configs #63
• FTR Configs #85
• FTR Configs #85
• Defend Workflows Cypress Tests on Serverless #3

Test Failures

• [job] [logs] FTR Configs #85 / discover/group3 discover request counts ES|QL mode should send 2 requests for saved search changes
• [job] [logs] FTR Configs #85 / discover/group3 discover request counts ES|QL mode should send 2 requests for saved search changes
• [job] [logs] FTR Configs #9 / discover/group4 indexpattern without timefield should allow switching from a saved search with a time field to a saved search without a time field
• [job] [logs] FTR Configs #9 / discover/group4 indexpattern without timefield should allow switching from a saved search with a time field to a saved search without a time field
• [job] [logs] FTR Configs #63 / lens app - group 1 lens ad hoc data view tests should navigate to discover correctly
• [job] [logs] FTR Configs #63 / lens app - group 1 lens ad hoc data view tests should navigate to discover correctly
• [job] [logs] FTR Configs #52 / management Index patterns on aliases should be able to discover and verify no of hits for alias1
• [job] [logs] FTR Configs #52 / management Index patterns on aliases should be able to discover and verify no of hits for alias1
• [job] [logs] FTR Configs #17 / security app dls user East should only see EAST doc
• [job] [logs] FTR Configs #17 / security app dls user East should only see EAST doc
• [job] [logs] FTR Configs #10 / transform - creation - index pattern creation_index_pattern batch transform with terms group and percentiles agg navigates to discover and displays results of the destination index
• [job] [logs] FTR Configs #10 / transform - creation - index pattern creation_index_pattern batch transform with terms group and percentiles agg navigates to discover and displays results of the destination index
• [job] [logs] FTR Configs #13 / transform basic license transform - creation - index pattern creation_index_pattern batch transform with terms group and percentiles agg navigates to discover and displays results of the destination index
• [job] [logs] FTR Configs #13 / transform basic license transform - creation - index pattern creation_index_pattern batch transform with terms group and percentiles agg navigates to discover and displays results of the destination index
• [job] [logs] Jest Tests #10 / useTotalHits should call onTotalHitsChange with an error status if fetch fails
• [job] [logs] Jest Tests #10 / useTotalHits should call searchSource.setOverwriteDataViewType if dataView is a rollup
• [job] [logs] Jest Tests #10 / useTotalHits should fetch a second time if refetch$ is triggered
• [job] [logs] Jest Tests #10 / useTotalHits should fetch total hits if isPlainRecord is true
• [job] [logs] Jest Tests #10 / useTotalHits should fetch total hits on first execution
• [job] [logs] Jest Tests #10 / useTotalHits should not fetch a second time if refetch$ is not triggered

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
unifiedHistogram	51.1KB	51.0KB	-17.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

[jughosta]

Closing in favor of #171638