Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Category job results API test #172840

Merged
merged 7 commits into from
Dec 11, 2023
Merged

[ML] Category job results API test #172840

merged 7 commits into from
Dec 11, 2023

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Dec 7, 2023 •
edited by kibanamachine
Loading

Creates a categorization job and tests:
The response from /internal/ml/jobs/top_categories matches the expected top categories.
The response from /internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId} matches the correct selected category.

Part of #168458

@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 7, 2023 16:48
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner December 7, 2023 16:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic self-assigned this Dec 7, 2023
@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Dec 7, 2023
@jgowdyelastic jgowdyelastic mentioned this pull request Dec 7, 2023
Closed
8 tasks
@jgowdyelastic jgowdyelastic marked this pull request as draft December 8, 2023 10:58
@jgowdyelastic jgowdyelastic changed the title [ML] Top categories API test [ML] Category job results API test Dec 8, 2023
@jgowdyelastic jgowdyelastic marked this pull request as ready for review December 8, 2023 12:23
peteharverson
peteharverson approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those extra tests. LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #2 / Actions and Triggers app Rule Details Edit rule button should reset rule when canceling an edit

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@jgowdyelastic jgowdyelastic merged commit efe8362 into elastic:main Dec 11, 2023
@kibanamachine kibanamachine mentioned this pull request Dec 11, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2023
@jgowdyelastic
[ML] Category job results API test (elastic#172840)
997f182 
Creates a categorization job and tests:
The response from `/internal/ml/jobs/top_categories` matches the
expected top categories.
The response from
`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`
matches the correct selected category.

Part of elastic#168458

(cherry picked from commit efe8362)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 11, 2023
@kibanamachine @jgowdyelastic
[8.12] [ML] Category job results API test (#172840) (#173023)
92e4828 
# Backport

This will backport the following commits from `main` to `8.12`:
- [[ML] Category job results API test
(#172840)](#172840)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"James
Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-11T09:04:50Z","message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","Feature:Anomaly
Detection","release_note:skip","v8.12.0","v8.13.0"],"number":172840,"url":"https://github.com/elastic/kibana/pull/172840","mergeCommit":{"message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/172840","number":172840,"mergeCommit":{"message":"[ML]
Category job results API test (#172840)\n\nCreates a categorization job
and tests:\r\nThe response from `/internal/ml/jobs/top_categories`
matches the\r\nexpected top categories.\r\nThe response
from\r\n`/internal/ml/anomaly_detectors/${jobId}/results/categories/${categoryId}`\r\nmatches
the correct selected category.\r\n\r\nPart of
https://github.com/elastic/kibana/issues/168458","sha":"efe8362d23a6f82005195df41c17271c2f48e0db"}}]}]
BACKPORT-->

Co-authored-by: James Gowdy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@qn895 qn895 Awaiting requested review from qn895

Assignees

@jgowdyelastic jgowdyelastic

Labels
Feature:Anomaly Detection ML anomaly detection :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes v8.12.0 v8.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibana-ci @kibanamachine @peteharverson